Alias change reloads filter twice
After changing an alias, the filter reloads twice, which can lead to a race condition "device busy" like the attached.
Jan 10 17:55:04 check_reload_status: syncing firewall Jan 10 17:55:04 check_reload_status: reloading filter Jan 10 17:55:06 check_reload_status: reloading filter
Seems a large alias, such as a URL one for all US CIDR blocks, can replicate the problem (see attached) more readily than typical rulesets.
#1 Updated by Pierre POMES over 8 years ago
The first cal to filter_configure() occurs when saving the changes in firewall_aliases_edit.php.
The second one occurs when the user cliks on "apply changes" in firewall_aliases.php.
Hum... does it mean the changes are already applied before clicking on the "apply changes" button ?
#2 Updated by Pierre POMES over 8 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Keep the same logic as for firewall rules, and remove call to filter_configure when user saves the changes in firewall_aliases_edit.php (reloading will be done when user will click on "apply changes")