Bug #1183: Alias change reloads filter twice - pfSense - pfSense bugtracker

Actions

Copy link

Bug #1183

closed

Alias change reloads filter twice

Added by Chris Buechler almost 14 years ago. Updated almost 14 years ago.

Status:

Resolved

Priority:

High

Assignee:

Category:

Rules / NAT

Target version:

2.0

Start date:

01/10/2011

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.0

Affected Architecture:

Description

After changing an alias, the filter reloads twice, which can lead to a race condition "device busy" like the attached.

Jan 10 17:55:04    check_reload_status: syncing firewall
Jan 10 17:55:04    check_reload_status: reloading filter
Jan 10 17:55:06    check_reload_status: reloading filter

Seems a large alias, such as a URL one for all US CIDR blocks, can replicate the problem (see attached) more readily than typical rulesets.

Files

reloaderrors.png (89.9 KB) reloaderrors.png

Chris Buechler, 01/10/2011 06:01 PM

Actions

Copy link

Updated by Pierre POMES almost 14 years ago

The first cal to filter_configure() occurs when saving the changes in firewall_aliases_edit.php.
The second one occurs when the user cliks on "apply changes" in firewall_aliases.php.

Hum... does it mean the changes are already applied before clicking on the "apply changes" button ?

Actions

Copy link

Updated by Pierre POMES almost 14 years ago

Status changed from New to Feedback
% Done changed from 0 to 100

Keep the same logic as for firewall rules, and remove call to filter_configure when user saves the changes in firewall_aliases_edit.php (reloading will be done when user will click on "apply changes")

Actions

Copy link