Project

General

Profile

Bug #1193

Traffic Shaper default queue Problem

Added by igor igor over 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Traffic Shaper
Target version:
Start date:
01/14/2011
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

As reported here a bug in traffic shaper:

When 2 or more queues are selected as default queue, you get a
There were error(s) loading the rules: pfctl: should have one default queue on pppoe0pfctl: errors in altq config The line in question reads [ should have one default queue on pppoe0pfctl]:

Better would be a control to avoid this.

Associated revisions

Revision acebc1ec (diff)
Added by Ermal Luçi about 8 years ago

Ticket #1193. Do not show default queue checkbox when another queue has it selected.

Revision 0b664809 (diff)
Added by Ermal Luçi about 8 years ago

Ticket #1193. Do not show default queue checkbox when another queue has it selected.

Revision 401869ec (diff)
Added by Ermal Luçi almost 8 years ago

Resolves #1193. Properly warn about duplicate default queue

Revision f61dc8e6 (diff)
Added by Ermal Luçi almost 8 years ago

Resolves #1193. Properly warn about duplicate default queue

History

#1 Updated by Chris Buechler over 8 years ago

  • Target version set to 2.0

#2 Updated by Chris Buechler over 8 years ago

  • Assignee deleted (Ermal Luçi)

#3 Updated by Ermal Luçi about 8 years ago

  • Status changed from New to Feedback

Plese test latest snapshots.

#4 Updated by Josh Stompro almost 8 years ago

Testing 2.0-RC3 I386 Built on Mon Aug 8 19:26:45 EDT 2011 nanobsd 2g

The logic to not show the default queue checkbox only looks at queues at the same level. With the current logic of having qLink and qInternet at the same level, when qLink is set to the default, no default checkbox is shown for qInternet, but it is shown for children of qInternet. I can check the default checkbox on qInternet->qP2P, and the system does not complain about it. The lower level default queue seems to take precedence. This may just be how it is supposed to work.

altq on  vr1_vlan1 hfsc queue {  qLink,  qInternet  } 
 queue qLink on vr1_vlan1 bandwidth 20% qlimit 500 hfsc (  ecn  , default  )  
 queue qInternet on vr1_vlan1 bandwidth 2500Kb hfsc (  ecn  , linkshare 2500Kb  , upperlimit 2500Kb  )  {  qACK,  qP2P,  qOthersHigh,  qOthersLow  } 
 queue qACK on vr1_vlan1 bandwidth 20% hfsc (  ecn  , linkshare 20%  )  
 queue qP2P on vr1_vlan1 bandwidth 5% hfsc (  ecn  , default  , linkshare 5%  , upperlimit 5%  )  
 queue qOthersHigh on vr1_vlan1 bandwidth 10% hfsc (  ecn  , linkshare 10%  )  
 queue qOthersLow on vr1_vlan1 bandwidth 5% hfsc (  ecn  , linkshare 5%  ) 

If this is how it should work then I think this ticket may be resolved.
Josh

#5 Updated by Ermal Luçi almost 8 years ago

  • % Done changed from 0 to 100

#6 Updated by Ermal Luçi almost 8 years ago

#7 Updated by Chris Buechler almost 8 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF