pfSense

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/279

Jim Pingle wrote in #note-5:

Applied in changeset commit:bec6dcfbbef4832b34d47ca60b0671b23dc185d8.

• 1. `ipsec_get_phase1_src()` - always executes `get_interface_ip/ipv6`, even if no appropriate protocol is selected
  - I see a fix for this issue in this commit

• 2. `ipsec_setup_secrets()` - always writes CRL files, even if there is no PH1 cert authentication
• 3. `resolve_retry()` - set `$retries = 10` it can significantly improve FQDN resolution time:
  - but not for these two

Viktor Gurov wrote in #note-6:

• 2. `ipsec_setup_secrets()` - always writes CRL files, even if there is no PH1 cert authentication
• 3. `resolve_retry()` - set `$retries = 10` it can significantly improve FQDN resolution time:
  - but not for these two

I didn't change those as they didn't appear to slow things down in my testing. They were not the primary causes of slowness I observed, anyhow. Though I didn't try with a failed DNS setup.

We can still do those, but they may be better suited for a separate Redmine issues if we decide to implement them. We should only have one change per issue to avoid cases like this where multiple suggestions are put into one place and there isn't a way to track them individually, as really those are separate bugs/optimizations.

New issues: #12195 and #12196