pfSense

A quick look at the code tells me this is likely the same root cause as what is making the IPsec status and apply process slow, which I'm in the middle of fixing already. I'll take a look at this when I finish up what I'm doing with IPsec.

Applied in changeset commit:87011dce1fe88ad48c098d6b6804add53cf64084.

Jim Pingle wrote in #note-2:

Applied in changeset commit:87011dce1fe88ad48c098d6b6804add53cf64084.

Hi, Jim. Appreciate the quick turnaround. Unfortunately, that patch still didn't get the page load times down to a usable level.

For testing I used an interface consisting of a set of 75 rules, 49 of which have gateways defined.

• v21.05 time to load was ~37 seconds.

• changeset 87011dce1fe88ad48c098d6b6804add53cf64084 time to load was ~21 seconds.

• I cobbled together a patch that gets the same page to load in ~3 seconds.

I'm only just learning how you've got the code organized, so there is bound to be something about this that doesn't conform to your standards. Though, is there anything inherently wrong with this approach (attached)?

The main problems with that are:

• You're moving too much of that logic onto the page and out of the include file. Could maybe be split into two functions in guiconfig.inc, but it should stay in there one way or another
• You've lost a bit of validation to ensure things like the gateways in the config are actually defined/are an array. Not every configuration has a gateway config and the "after" code here is making some faulty assumptions

Either way, this should be submitted as a PR on github which allows for much better collaboration: https://docs.netgate.com/pfsense/en/latest/development/pull-request.html

PR has been merged. Thanks!

Updating subject for release notes.

This seems to be working fine here.