Feature #12349
closed
Disks dashboard widget to replace Disk Usage section of System Information widget
Added by Christian McDonald over 2 years ago.
Updated over 2 years ago.
Plus Target Version:
22.01
Description
Notables:
- Removes disk usage information from System Information widget.
- Collapsible treegrid interface to hierarchically display mount paths.
- Treegrid state is preserved across ajax updates.
- User can specify specific mounts to 'pin' at the top of the table.
- Mounts exceeding the `Auto Show Threshold` are automatically pinned at the top in an alert state.
PR : https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/372
- Description updated (diff)
- Subject changed from Add Disks dashboard widget to Disks dashboard widget to replace Disk Usage section of System Information widget
- Priority changed from Urgent to Normal
Updating subject for release notes
- Status changed from Pull Request Review to New
PR was merged yesterday, it's in snapshots today.
Looks like there is a bug in the upgrade code. The dashboard widgets do not always have an index value, so the entry in the widget array for the new entry ended up with an extra trailing :
- <sequence>system_information:col1:show,netgate_services_and_support:col2:show,interfaces:col2:show</sequence>
+ <sequence>system_information:col1:show,disks:col1:show:,netgate_services_and_support:col2:show,interfaces:col2:show</sequence>
That's on a system which is using a default configuration.
Removing the extra trailing : from the entry makes it show up as expected.
ah good catch. Bad assumption on my part. Easy to fix.
- Status changed from New to Feedback
Upgrade looks good with that change applied, I rolled back the config and triggered the upgrade code again and this time the widget displayed. Only quirk is that on a config with an index when it is 0, it gets omitted, but that should be safe as it assumes 0 if it's unset. Since the outcome is equivalent in either case it's probably not worth messing with.
Will leave open for a bit yet for more feedback on the widget in general.
- Status changed from Feedback to Closed
Upgraded and tested on a variety of different filesystem type installs (old and newer ZFS with different dataset layouts, UFS) and it seems to be OK in all cases I've seen.
There is a minor GUI issue when only two entries are in the list but it's not a blocker, I opened #12368 for it, and it can wait for the next release.
- Target version changed from CE-Next to 2.6.0
- Plus Target Version changed from 21.09 to 22.01
Also available in: Atom
PDF
Updated by 
Updated by