Project

General

Profile

Actions
Copy link

Bug #12388

closed
JP VG

Captive Portal input validation for "After authentication Redirection URL" and "Blocked MAC address redirect URL" is swapped

Bug #12388: Captive Portal input validation for "After authentication Redirection URL" and "Blocked MAC address redirect URL" is swapped

Added by Jim Pingle almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Captive Portal
Target version:
2.6.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

On services_captiveportal.php the input validation for "After authentication Redirection URL" and "Blocked MAC address redirect URL" is swapped.

The error message when checking redirurl refers to "Blocked MAC address redirect URL" when it should be "After authentication Redirection URL".

The error message when checking blockedmacsurl refers to "After authentication Redirection URL" when it should be "Blocked MAC address redirect URL".

JP Updated by Jim Pingle almost 5 years ago Actions
Copy link
 #2

  • Status changed from New to Pull Request Review
  • Assignee changed from Jim Pingle to Viktor Gurov

EE Updated by eyenop eyenop almost 5 years ago Actions
Copy link
 #3

hello, how can i solve this problem with this page showing? eyeg

VG Updated by Viktor Gurov almost 5 years ago Actions
Copy link
 #4

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:14e080ab41419b4006130432c1e128deaaffdee0.

DZ Updated by Danilo Zrenjanin almost 5 years ago Actions
Copy link
 #5

  • Status changed from Feedback to Resolved

Tested on the:

2.6.0-DEVELOPMENT (amd64)
built on Sat Oct 09 05:20:31 UTC 2021
FreeBSD 12.2-STABLE

It's ok now. Ticket resolved.

JP Updated by Jim Pingle almost 5 years ago Actions
Copy link
 #6

  • Target version changed from CE-Next to 2.6.0
Actions
Copy link

Also available in: Atom