Project

General

Profile

Actions

Regression #12396

closed

PHP Warning: Use of undefined constant ip - /etc/inc/services.inc on line 2465

Added by JP Versteeg over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
PHP Interpreter
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Force Exclusion
Affected Version:
Affected Architecture:

Description

Hi Team,
Could you please confirm. Many thanks.

Issue identified following the first reboot, after fully completing installation of 21.09RC upgrading from 21.02.

Error produced in GUI
PHP Warning:
Use of undefined constant ip - assumed 'ip' (this will throw an Error in a future version of PHP) in /etc/inc/services.inc on line 2465

A comparison of the local file with github showed the same line in both.
line 2465 /etc/inc/services.inc
line 2465 https://github.com/pfsense/pfsense/blob/master/src/etc/inc/services.inc

  1. Proposed change
  1. /etc/inc/services.inc line 2461-2469

/* Setup forwarded domains */
if (isset($config['dnsmasq']['domainoverrides']) && is_array($config['dnsmasq']['domainoverrides'])) {
foreach ($config['dnsmasq']['domainoverrides'] as $override) {
if ($override['ip'] == "!") {
- $override[ip] = "";
+ $override['ip'] = "";
}
$args .= ' --server=/' . $override['domain'] . '/' . $override['ip'];
}
}

Actions

Also available in: Atom PDF