Project

General

Profile

Actions
Copy link

Todo #12431

open

GUI pages should use ``POST`` for AJAX calls, not ``GET``

Added by Jim Pingle 9 months ago. Updated 6 days ago.

Status:
Pull Request Review
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Web Interface
Target version:
CE-Next
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.11
Release Notes:
Default

Description

The AJAX buttons on the OpenVPN status page submit values using GET when they should use POST. The variables used in the backend portion of the call use $_REQUEST when they should only use $_POST.

Actions
Copy link
 #1

Updated by Viktor Gurov 9 months ago

also:

pkg.php
services_captiveportal_vouchers.php
vendorstatus_graph.php
vpn_ipsec_phase1.php
status_graph.php
widgets/gmirror_status.widget.php
widgets/interface_statistics.widget.php
widgets/openvpn.widget.php

Actions
Copy link
 #2

Updated by Jim Pingle 9 months ago

  • Subject changed from OpenVPN status page should use ``POST`` for AJAX calls, not ``GET`` to GUI pages should use ``POST`` for AJAX calls, not ``GET``
  • Category changed from OpenVPN to Web Interface

True. May as well fix them all. Updated subject/category.

Actions
Copy link
 #4

Updated by Jim Pingle 9 months ago

  • Status changed from New to Pull Request Review
  • Assignee set to Viktor Gurov
Actions
Copy link
 #5

Updated by Jim Pingle 6 months ago

  • Target version changed from 2.6.0 to CE-Next
  • Plus Target Version changed from 22.01 to 22.05

Need more comprehensive testing.

Actions
Copy link
 #6

Updated by Jim Pingle about 2 months ago

  • Plus Target Version changed from 22.05 to 22.09
Actions
Copy link
 #7

Updated by Jim Pingle 6 days ago

  • Plus Target Version changed from 22.09 to 22.11
Actions
Copy link

Also available in: Atom PDF