Todo #12431: GUI pages should use ``POST`` for AJAX calls, not ``GET`` - pfSense - pfSense bugtracker

Custom queries

2.4.5-p1 - Resolved/Closed
2.5.0 - Resolved/Closed
2.5.1 - Resolved/Closed
2.5.2 - Resolved/Closed
2.6.0 - Resolved/Closed
2.7.0 - Resolved/Closed
2.7.1 - All Open Issues
2.7.1 - Resolved/Closed
2.7.2 - Resolved/Closed
2.8.0 - All Open Bugs
2.8.0 - All Open Features
2.8.0 - All Open Issues
2.8.0 - All Open Regressions
2.8.0 - Feedback
2.8.0 - Needs Attention
2.8.0 - New/Confirmed
2.8.0 - Pull Requests
2.8.0 - Regressions affecting 2.7.0
2.8.0 - Resolved/Closed
21.02.2/2.5.1 - Resolved/Closed
21.05 Plus - All Closed Issues
21.05.1 Plus Target - All Closed Issues
21.05.1 Target - All Closed Issues
22.01 Plus - All Closed Issues
22.01 Target - All Closed Issues
22.05 Plus - All Closed Issues
22.05 Target - All Closed Issues
23.01 Plus - All Closed Issues
23.01 Target - All Closed Issues
23.05 Plus - All Closed Issues
23.05 Target - All Closed Issues
23.05.1 Plus - All Closed Issues
23.05.1 Target - All Closed Issues
23.09 Plus - All Closed Issues
23.09 Target - All Closed Issues
23.09.1 Plus - All Closed Issues
23.09.1 Plus - All Open Issues
23.09.1 Target - All Closed Issues
23.09.1 Target - All Open Issues
24.03 Plus - All Closed Issues
24.03 Plus - All Open Issues
24.03 Plus - Feedback Issues
24.03 Plus - Needs Attention/Work
24.03 Plus - New/Confirmed/In Progress Issues
24.03 Plus - Pull Request Review
24.03 Plus - Waiting on Merge
24.03 Target - All Closed Issues
24.03 Target - All Open Issues
All Open Issues assigned to Me
All Open Pull Requests
Any Target - All Open Regressions
Any Target - Feedback Issues
CE-Next - All Closed Issues (Move to specific target)
CE-Next - All Open Issues
CE-Next - Feedback (Likely needs target changed)
New Issues by Category - Future Target
New Issues by Category - No Target
New Issues by Category - No Target+Future
No Target - All Open Issues (Base Only)
No Target - New Issues (Base Only)
No Target - New Issues (Base and Packages)
Release Notes - Plus Target Version (DO NOT EDIT)
Release Notes - Target Version (DO NOT EDIT)

Actions

Copy link

Todo #12431

closed

GUI pages should use ``POST`` for AJAX calls, not ``GET``

Added by Jim Pingle over 2 years ago. Updated 10 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jim Pingle

Category:

Web Interface

Target version:

2.7.0

Start date:

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

23.09

Release Notes:

Default

Description

The AJAX buttons on the OpenVPN status page submit values using GET when they should use POST. The variables used in the backend portion of the call use $_REQUEST when they should only use $_POST.

Files

Download all files

429.diff (7.51 KB) 429.diff		Jim Pingle, 06/06/2023 04:39 PM
429-working.diff (7.34 KB) 429-working.diff		Jim Pingle, 06/06/2023 05:40 PM

History
Notes
Property changes

Actions

Copy link

Updated by Viktor Gurov over 2 years ago

also:

pkg.php
services_captiveportal_vouchers.php
vendorstatus_graph.php
vpn_ipsec_phase1.php
status_graph.php
widgets/gmirror_status.widget.php
widgets/interface_statistics.widget.php
widgets/openvpn.widget.php

Actions

Copy link

Updated by Jim Pingle over 2 years ago

Subject changed from OpenVPN status page should use ``POST`` for AJAX calls, not ``GET`` to GUI pages should use ``POST`` for AJAX calls, not ``GET``
Category changed from OpenVPN to Web Interface

True. May as well fix them all. Updated subject/category.

Actions

Copy link

Updated by Viktor Gurov over 2 years ago

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/429

Actions

Copy link

Updated by Jim Pingle over 2 years ago

Status changed from New to Pull Request Review
Assignee set to Viktor Gurov

Actions

Copy link

Updated by Jim Pingle over 2 years ago

Target version changed from 2.6.0 to CE-Next
Plus Target Version changed from 22.01 to 22.05

Need more comprehensive testing.

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Plus Target Version changed from 22.05 to 22.09

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Plus Target Version changed from 22.09 to 22.11

Actions

Copy link

Updated by Jim Pingle over 1 year ago

Plus Target Version changed from 22.11 to 23.01

Actions

Copy link

Updated by Jim Pingle over 1 year ago

Assignee deleted (~~Viktor Gurov~~)
Target version changed from CE-Next to 2.7.0
Plus Target Version changed from 23.01 to 23.05

Actions

Copy link

#10

Updated by Jim Pingle 11 months ago

Plus Target Version changed from 23.05 to 23.09

Actions

Copy link

#11

Updated by Jim Pingle 10 months ago

Assignee set to Jim Pingle

Actions

Copy link

#12

Updated by Jim Pingle 10 months ago

File 429.diff 429.diff added
Status changed from Pull Request Review to In Progress

Previous MR had conflicts, but I reworked it so it applies against current code for wider testing. See attached.

Actions

Copy link

#13

Updated by Jim Pingle 10 months ago

File 429-working.diff 429-working.diff added

I tested each of the changes in the diff and found some problems, and also fixed them. Fixed diff attached, passes all my tests at least. Will be committing shortly.

Actions

Copy link

#14