Project

General

Profile

Actions
Copy link

Bug #12527

closed

DHCPv6 server does not skip interfaces configured with invalid ranges

Added by Michael Lindman over 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Jim Pingle
Category:
DHCP (IPv6)
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
2.5.2
Affected Architecture:

Files

814.diff (2 KB) 814.diff Jim Pingle, 06/02/2022 08:18 AM
Actions
Copy link
 #1

Updated by Michael Lindman over 2 years ago

When configuring the DHCPv6 Server errors on other interfaces that break the DHCPv6 server as a whole are not detected or warned about in the user interface. I had an out of range subnet on one of my interfaces that wasn't noticed which stopped the DHCPv6 server from issuing addresses to clients on every other interface and was only noticed after looking at the DHCPv6 server logs which indicated an error on line 45 which was the out of range subnet.

Actions
Copy link
 #2

Updated by Viktor Gurov over 2 years ago

  • Affected Version set to 2.5.2
Actions
Copy link
 #3

Updated by Jim Pingle over 2 years ago

  • Target version set to CE-Next
  • Plus Target Version set to 22.05
Actions
Copy link
 #4

Updated by Jim Pingle over 2 years ago

  • Status changed from New to Pull Request Review
  • Assignee set to Viktor Gurov
Actions
Copy link
 #5

Updated by Viktor Gurov about 2 years ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Jim Pingle about 2 years ago

  • Target version changed from CE-Next to 2.7.0
Actions
Copy link
 #7

Updated by Jim Pingle about 2 years ago

  • Subject changed from DHCPv6 configuration doesn't detect errors on not configured interface to DHCPv6 server does not skip interfaces configured with invalid ranges

Updating subject for release notes.

Actions
Copy link
 #8

Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Viktor Gurov to Jim Pingle
  • Priority changed from Normal to Urgent

This caused a regression where it's skipping dhcp6 for delegated prefixes.

Actions
Copy link
 #9

Updated by Jim Pingle almost 2 years ago

MR: https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/814

Patch is attached and fixes it for me here in my lab setup and for others testing internally.

Actions
Copy link
 #10

Updated by Jim Pingle almost 2 years ago

  • Status changed from Assigned to Feedback
Actions
Copy link
 #11

Updated by Jim Pingle almost 2 years ago

Patch was tested successfully by multiple people internally, including several dynamic and static systems in my lab. Looks OK now.

Actions
Copy link
 #12

Updated by Jim Pingle almost 2 years ago

If nobody else offers feedback before 22.05 releases, this is OK to close. The change appears to be solid but I'd like to test it again when it's in a build.

Actions
Copy link
 #13

Updated by Danilo Zrenjanin almost 2 years ago

The patch did the job.

Tested:

2.7.0-DEVELOPMENT (amd64)
built on Wed Jun 01 06:12:27 UTC 2022
FreeBSD 12.3-STABLE

Actions
Copy link
 #14

Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to Resolved

Works on latest internal test snapshot.

Actions
Copy link

Also available in: Atom PDF