Project

General

Profile

Actions
Copy link

Bug #12694

closed
RB JP

PHP error when clicking Delete on Outbound NAT with no rules selected

Bug #12694: PHP error when clicking Delete on Outbound NAT with no rules selected

Added by Renato Botelho over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Rules / NAT
Target version:
2.6.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

After pressing Delete button without selecting any NAT rule I got a PHP crash as follow:

PHP Errors:
[18-Jan-2022 10:53:05 America/Sao_Paulo] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/pfSense/include/www/firewall_nat_out.inc on line 496

SL Updated by Scott Long over 4 years ago Actions
Copy link
 #1

  • Assignee set to Jim Pingle

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #2

  • Subject changed from Outbound NAT: Error when press delete button without select rules to PHP error when clicking Delete on Outbound NAT with no rules selected
  • Status changed from New to In Progress

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #3

  • Status changed from In Progress to Pull Request Review

SL Updated by Scott Long over 4 years ago Actions
Copy link
 #4

  • Status changed from Pull Request Review to Feedback

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #5

  • % Done changed from 0 to 100

Applied in changeset commit:f783d68bd1708f7845fc21f035b4f3232a6f435d.

DZ Updated by Danilo Zrenjanin over 4 years ago Actions
Copy link
 #6

Tested on:

2.6.0-RC (amd64)
built on Mon Jan 17 23:21:01 UTC 2022
FreeBSD 12.3-STABLE

I was able to replicate the issue.

With the patch installed, it's gone. The ticket can be resolved.

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #7

  • Status changed from Feedback to Resolved

Same here. No more PHP error when attempting to reproduce the problem. Selecting and deleting items still works as expected.

Actions
Copy link

Also available in: Atom