Project

General

Profile

Actions

Bug #12694

closed

PHP error when clicking Delete on Outbound NAT with no rules selected

Added by Renato Botelho 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Rules / NAT
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

After pressing Delete button without selecting any NAT rule I got a PHP crash as follow:

PHP Errors:
[18-Jan-2022 10:53:05 America/Sao_Paulo] PHP Warning:  Invalid argument supplied for foreach() in /usr/local/pfSense/include/www/firewall_nat_out.inc on line 496
Actions #1

Updated by Scott Long 4 months ago

  • Assignee set to Jim Pingle
Actions #2

Updated by Jim Pingle 4 months ago

  • Subject changed from Outbound NAT: Error when press delete button without select rules to PHP error when clicking Delete on Outbound NAT with no rules selected
  • Status changed from New to In Progress
Actions #3

Updated by Jim Pingle 4 months ago

  • Status changed from In Progress to Pull Request Review
Actions #4

Updated by Scott Long 4 months ago

  • Status changed from Pull Request Review to Feedback
Actions #5

Updated by Jim Pingle 4 months ago

  • % Done changed from 0 to 100
Actions #6

Updated by Danilo Zrenjanin 4 months ago

Tested on:

2.6.0-RC (amd64)
built on Mon Jan 17 23:21:01 UTC 2022
FreeBSD 12.3-STABLE

I was able to replicate the issue.

With the patch installed, it's gone. The ticket can be resolved.

Actions #7

Updated by Jim Pingle 4 months ago

  • Status changed from Feedback to Resolved

Same here. No more PHP error when attempting to reproduce the problem. Selecting and deleting items still works as expected.

Actions

Also available in: Atom PDF