Feature #12714: Show ``Inactive`` for Hardware Crypto output instead of empty field on System Information dashboard widget when nothing can be accelerated - pfSense - pfSense bugtracker

Actions

Copy link

Feature #12714

closed

Show ``Inactive`` for Hardware Crypto output instead of empty field on System Information dashboard widget when nothing can be accelerated

Added by → luckman212 almost 3 years ago. Updated over 2 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jim Pingle

Category:

Dashboard

Target version:

2.7.0

Start date:

Due date:

% Done:

Estimated time:

Plus Target Version:

22.05

Release Notes:

Default

Description

on 22.01.r.20220120.1938 I'm seeing an empty string on the Dashboard Widget under System Information -> Hardware crypto:

I looked at the code, e.g.
https://github.com/pfsense/pfsense/blob/f73ace96e837ca2f0957a5fafe5794e033231c2e/src/usr/local/www/includes/functions.inc.php#L306

I guess it might not show anything there unless the crypto alg is being actively used?

But what is the intent of this display- to show capabilities or what's actually in use? (I thought capabilities...)

Here's a display from a 5100 running 2.4.5:

Actions

Copy link

Updated by Jim Pingle almost 3 years ago

Status changed from New to Not a Bug
Plus Target Version deleted (~~22.01~~)

It's working fine here on the latest RC on 6100 and several other platforms.

From the output in the widget above you don't have AES-NI nor QAT loaded (both say "inactive") so it's accurately saying nothing will be accelerated.

In the lower screenshot you have AES-NI active, so it's showing what it would accelerate.

If I have one or the other module loaded, it shows the expected list of ciphers. If I disable all of the acceleration modules and reboot, the field is blank, which is expected and correct.

Actions

Copy link

Updated by → luckman212 almost 3 years ago

Okay thanks Jim

FYI I have my crypto set to "QAT" on the 6100... which also seems to be the default setting.

So it's correct that the widget displays what's ACTIVE on the system, not what it SUPPORTS? Was this always true? Intuitively I would expect it to show what features are supported.

Actions

Copy link

Updated by Jim Pingle almost 3 years ago

It does show both supported (See the "Yes") and active/inactive. The Yes/No is whether or not the hardware supports the function, the active/inactive is whether or not the module is loaded. It's all there in the widget.

Actions

Copy link

Updated by → luckman212 almost 3 years ago

Ok, I would suggest a small wording change then

"Hardware crypto" → "Hardware crypto (active)"

And the crypto_accel_get_algs() function should return "Inactive" instead of an empty string in case $algs_str is empty....

Just would be clearer imo. If you're ok with it I can make a PR for this.

Actions

Copy link

Updated by → luckman212 almost 3 years ago

Jim Pingle it was a 1-line PR so I just went ahead...

https://github.com/pfsense/pfsense/pull/4553

Actions

Copy link

Updated by → luckman212 almost 3 years ago

Can this be "un-closed" so the PR can be considered

Actions

Copy link

Updated by Jim Pingle almost 3 years ago

Tracker changed from Bug to Feature
Subject changed from Dashboard - System Information > Hardware Crypto returns empty string on 22.01 rc to Show ``Inactive`` for Hardware Crypto output instead of empty field on System Information dashboard widget when nothing can be accelerated
Status changed from Not a Bug to Pull Request Review
Target version set to CE-Next
Plus Target Version set to Plus-Next