Project

General

Profile

Actions

Regression #13126

closed

NAT rules are not saving properly, they are losing the `local-port` value

Added by → luckman212 almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
Rules / NAT
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Force Exclusion
Affected Version:
2.7.0
Affected Architecture:

Description

22.05.a.20220426.1313

Before:

After saving (making no changes):

Inspecting the XML for the rule reveals that 1 key was added and 1 key removed.

added: <ipprotocol>inet</ipprotocol>
removed: <local-port>sync_mini</local-port>

I don't know if this is related to https://redmine.pfsense.org/issues/13106 but it seems possible.


Files

clipboard-202205041149-l0d02.png (23.6 KB) clipboard-202205041149-l0d02.png → luckman212, 05/04/2022 10:49 AM
clipboard-202205041151-dajh4.png (21.3 KB) clipboard-202205041151-dajh4.png → luckman212, 05/04/2022 10:51 AM
Actions #1

Updated by → luckman212 almost 2 years ago

I figured out the problem, and pushed a fix

PR: https://github.com/pfsense/pfsense/pull/4584

Actions #2

Updated by Jim Pingle almost 2 years ago

  • Project changed from pfSense Plus to pfSense
  • Category changed from Rules / NAT to Rules / NAT
  • Status changed from New to Pull Request Review
  • Target version set to 2.7.0
  • Release Notes changed from Default to Force Exclusion
  • Plus Target Version set to 22.05
Actions #3

Updated by Viktor Gurov almost 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Affected Version set to 2.7.0

PR merged, thanks!

Actions #4

Updated by Danilo Zrenjanin almost 2 years ago

  • Status changed from Feedback to Resolved

Tested:

22.05-DEVELOPMENT (amd64)
built on Fri May 06 17:34:40 UTC 2022
FreeBSD 12.3-STABLE

It works as expected. I am marking this ticket resolved.

Actions

Also available in: Atom PDF