Project

General

Profile

Actions
Copy link

Regression #13142

closed
SW JP

PHP shell ``pfanchordrill`` script produces errors on captive portal tables

Regression #13142: PHP shell ``pfanchordrill`` script produces errors on captive portal tables

Added by Steve Wheeler over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Console Menu
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Force Exclusion
Affected Version:
2.7.x
Affected Architecture:
All

Description

When running the pfanchordrill PHP shell script on a system with captive portal enabled the following errors are shown:

Netgate pfSense Plus shell: playback pfanchordrill 

Playback of file pfanchordrill started.

ipsec rules/nat contents:

miniupnpd rules/nat contents:

natearly rules/nat contents:

natrules rules/nat contents:

openvpn rules/nat contents:

tftp-proxy rules/nat contents:

userrules rules/nat contents:

cpzoneid_2_allowedhosts rules/nat contents:
pfctl: DIOCGETRULES: Invalid argument
pfctl: DIOCGETRULES: Invalid argument

cpzoneid_2_auth rules/nat contents:
pfctl: DIOCGETRULES: Invalid argument
pfctl: DIOCGETRULES: Invalid argument

cpzoneid_2_authmac rules/nat contents:
pfctl: DIOCGETRULES: Invalid argument
pfctl: DIOCGETRULES: Invalid argument

cpzoneid_2_passthrumac rules/nat contents:
pfctl: DIOCGETRULES: Invalid argument
pfctl: DIOCGETRULES: Invalid argument

Tested against: 22.05.a.20220509.2034

Related issues 2 (0 open — 2 closed)

Related to Regression #13106: ``pfanchordrill`` treating errors as anchor namesResolvedJim Pingle

Actions
Related to Todo #13100: Transition Captive Portal from IPFW to PFResolvedViktor Gurov

Actions

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #1

  • Subject changed from PHP shell pfanchordrill script produces errors to PHP shell ``pfanchordrill`` script produces errors on captive portal tables
  • Assignee set to Jim Pingle
  • Release Notes changed from Default to Force Exclusion

Similar to #13106 which should already be fixed in the repo but the behavior is slightly different. This isn't getting caught in a loop like that one was, but probably still needs some other adjustment.

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #2

  • Related to Regression #13106: ``pfanchordrill`` treating errors as anchor names added

VG Updated by Viktor Gurov over 4 years ago Actions
Copy link
 #3

  • Related to Todo #13100: Transition Captive Portal from IPFW to PF added

SW Updated by Steve Wheeler over 4 years ago Actions
Copy link
 #5

That patch fixes it for my use case shown above.

SW Updated by Steve Wheeler over 4 years ago Actions
Copy link
 #6

  • Status changed from New to Pull Request Review

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #7

  • Assignee changed from Jim Pingle to Viktor Gurov

VG Updated by Viktor Gurov over 4 years ago Actions
Copy link
 #8

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:6cdd2fda5c28fdca8171e14fdbd4b0eb98177ee1.

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #9

  • Status changed from Feedback to In Progress
  • Assignee changed from Viktor Gurov to Jim Pingle

This needs one more small fix as pfanchordrill is not catching the new captive portal nested anchors.

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #10

  • Status changed from In Progress to Feedback

Applied in changeset commit:af54e92e65495d8ad76eb9698d5ae6b709504c0b.

JP Updated by Jim Pingle over 4 years ago Actions
Copy link
 #11

  • Status changed from Feedback to Resolved

The contents of nested captive portal anchors are now displayed as expected.

Actions
Copy link

Also available in: Atom