Project

General

Profile

Actions
Copy link

Bug #13164

closed

Info icon on ``firewall_nat_out.php`` is incorrectly placed in manual outbound NAT mode

Added by → luckman212 over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Rules / NAT
Target version:
2.7.0
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

firewall_nat_out.php has a bug where the infoblock (i) is displayed wayyy off to the left of the main table when in manual outbound NAT mode. This appears due to the if ($mode == "automatic"... block not properly including the closing tags of the table/div elements when that table is not shown.

If you "view source" on the rendered page when in manual NAT mode, and run it through an HTML validator e.g. https://validator.w3.org/nu/#textarea — you'll see the errors as well.

I created the PR below, which works for me on my 22.05.b.20220512.0600 system, renders properly and passes validation. But I would appreciate another set of eyes on this fix to make sure it's correct.

before patch:

after patch:

Files

Download all files
clipboard-202205132304-ebayf.png (273 KB) clipboard-202205132304-ebayf.png → luckman212, 05/13/2022 10:05 PM
clipboard-202205132305-swmwx.png (243 KB) clipboard-202205132305-swmwx.png → luckman212, 05/13/2022 10:05 PM
Actions
Copy link
 #2

Updated by Jim Pingle over 2 years ago

  • Subject changed from firewall_nat_out.php error if in manual outbound NAT mode (infoblock) to Info icon on ``firewall_nat_out.php`` is incorrectly placed in manual outbound NAT mode
  • Category changed from Web Interface to Rules / NAT
  • Status changed from New to Pull Request Review
  • Target version set to 2.7.0
  • Plus Target Version set to 22.05
Actions
Copy link
 #3

Updated by Viktor Gurov over 2 years ago

  • Status changed from Pull Request Review to Feedback
Actions
Copy link
 #4

Updated by Danilo Zrenjanin over 2 years ago

  • Status changed from Feedback to Resolved

Tested:

2.7.0-DEVELOPMENT (amd64)
built on Thu May 19 06:14:05 UTC 2022
FreeBSD 12.3-STABLE

It works as expected. Marking this ticket resolved.

Actions
Copy link

Also available in: Atom PDF