Regression #13183
closedZFS module is loaded on systems without ZFS
0%
Description
A recent change in behavior is leading to the ZFS module getting loaded on systems that lack ZFS. When the user logs into the GUI the system is loading the ZFS kernel modules (zfs.ko
, opensolaris.ko
) even if the system lacks ZFS or can't support ZFS, such as 32-bit ARM systems.
This appears to be isolated to Plus installations only so may be related to ZFS boot environment code.
Updated by Christian McDonald over 2 years ago
- Status changed from Confirmed to Feedback
This should do it: https://gitlab.netgate.com/pfSense/factory/-/merge_requests/61
Updated by Jim Pingle over 2 years ago
Looks good so far. Applied patch on a 1000 and 3100 and rebooted, logged back into the GUI and the module remained unloaded. No ZFS console messages.
I'll test it again after the next snapshot.
Updated by Jim Pingle over 2 years ago
- Status changed from Feedback to Confirmed
The Dashboard instance is fixed, but I also found another way it can happen: During upgrade
Run pfSense-upgrade
from the shell on a system without ZFS and it's readily apparent that it's loading the module, but it shouldn't be:
: pfSense-upgrade -y warning: KLD '/boot/kernel/opensolaris.ko' is newer than the linker.hints file ZFS NOTICE: KSTACK_PAGES is 2 which could result in stack overflow panic! Please consider adding 'options KSTACK_PAGES=4' to your kernel config ZFS NOTICE: Prefetch is disabled by default if less than 4GB of RAM is present; to enable, add "vfs.zfs.prefetch_disable=0" to /boot/loader.conf. ZFS WARNING: Recommended minimum kmem_size is 512MB; expect unstable behavior. Consider tuning vm.kmem_size and vm.kmem_size_max in /boot/loader.conf. ZFS filesystem version: 5 ZFS storage pool version: features support (5000)
Updated by Christian McDonald over 2 years ago
- Status changed from Confirmed to Feedback
Fix merged. Try again.