Regression #13265: Authentication using Voucher cause SQLite3 syntax error - pfSense - pfSense bugtracker

Actions

Copy link

Regression #13265

closed

Authentication using Voucher cause SQLite3 syntax error

Added by Lev Prokofev over 2 years ago. Updated over 2 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Jim Pingle

Category:

Captive Portal

Target version:

2.7.0

Start date:

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

22.05

Release Notes:

Force Exclusion

Affected Version:

Affected Architecture:

All

Description

Errors:

Crash report begins. Anonymous machine information:

amd64
12.3-STABLE
FreeBSD 12.3-STABLE plus-RELENG_22_05-n202695-c0ae69858ce pfSense

Crash report details:

PHP Errors:
[10-Jun-2022 15:35:17 Etc/UTC] PHP Warning: SQLite3::exec(): near ",": syntax error in /etc/inc/captiveportal.inc on line 1487
[10-Jun-2022 15:35:17 Etc/UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /etc/inc/captiveportal.inc:1487) in /etc/inc/captiveportal.inc on line 1797
[10-Jun-2022 15:35:18 Etc/UTC] PHP Warning: SQLite3::exec(): near ",": syntax error in /etc/inc/captiveportal.inc on line 1487
[10-Jun-2022 15:35:18 Etc/UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /etc/inc/captiveportal.inc:1487) in /etc/inc/captiveportal.inc on line 1797
____________________

Steps to reproduce:

1)Create a captive portal with a Local Database backed
2)Enable Voucher
3)Add Voucher rolls
4)Use the Voucher code for authentication

Files

Download all files

PHP_errors (1).log (1.28 KB) PHP_errors (1).log		Lev Prokofev, 06/11/2022 05:06 AM
captive errors.png (61.1 KB) captive errors.png		Lev Prokofev, 06/11/2022 05:07 AM

Actions

Copy link

Updated by Kris Phillips over 2 years ago

I can confirm this issue is present in the RC3 build of 22.05.

Actions

Copy link

Updated by Kris Phillips over 2 years ago

Here is the crash report from my firewall:

Crash report begins. Anonymous machine information:

amd64
12.3-STABLE
FreeBSD 12.3-STABLE plus-RELENG_22_05-n202695-c0ae69858ce pfSense

Crash report details:

PHP Errors:
[11-Jun-2022 22:40:02 Etc/UTC] PHP Warning: SQLite3::exec(): near ",": syntax error in /etc/inc/captiveportal.inc on line 1487
[11-Jun-2022 22:40:02 Etc/UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /etc/inc/captiveportal.inc:1487) in /etc/inc/captiveportal.inc on line 1797
[11-Jun-2022 22:40:02 Etc/UTC] PHP Warning: SQLite3::exec(): near ",": syntax error in /etc/inc/captiveportal.inc on line 1487
[11-Jun-2022 22:40:02 Etc/UTC] PHP Warning: Cannot modify header information - headers already sent by (output started at /etc/inc/captiveportal.inc:1487) in /etc/inc/captiveportal.inc on line 1797

No FreeBSD crash data found.

Actions

Copy link

Updated by Jim Pingle over 2 years ago

Project changed from pfSense Plus to pfSense
Category changed from Captive Portal to Captive Portal
Status changed from New to In Progress
Assignee set to Jim Pingle
Priority changed from Normal to Urgent
Target version changed from 22.05 to 2.7.0
Affected Plus Version deleted (~~22.05~~)
Plus Target Version set to 22.05

It should be noted that the authentication succeeds and the user can get out, is listed on the active vouchers tab, but not the active users tab.

Looking at the failing query, the place for `pipeno` in the query is missing -- not '' but nothing at all , ,.

Formatted for ease of reading:

INSERT INTO captiveportal
  (allow_time, pipeno, ip, mac, username, sessionid, bpassword, session_timeout, idle_timeout, session_terminate_time, interim_interval, traffic_quota, bw_up, bw_down, authmethod, context)
VALUES
  (1655125710, , '10.7.0.10', '5e:13:3b:xx:xx:xx', 'nY3DVGQGHmJ', '8046d076f48c1dad', '', 3600, NULL, NULL, NULL, NULL, 0, 0, 'voucher', 'voucher')

Actions

Copy link