Project

General

Profile

Actions

Regression #13394

closed

``ASN1_NULL.php`` missing from package build of ``security/php-openssl_x509_crl`` on snapshots

Added by Jim Pingle over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
High
Category:
Operating System
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Force Exclusion
Affected Version:
Affected Architecture:

Description

Current snapshots of Plus 22.09 and CE 2.7.0 have a problem with the build of security/php-openssl_x509_crl where the file ASN1_NULL.php is not included in the resulting package archive or installed at /usr/local/share/openssl_x509_crl/ where it was in previous versions.

The file is in the pkg-plist in the repository: https://github.com/pfsense/FreeBSD-ports/blob/devel/security/php-openssl_x509_crl/pkg-plist#L8

And yet the file is not in the package that is built and installed:

: pkg info -l security/php-openssl_x509_crl
php74-openssl_x509_crl-1.3:
        /usr/local/share/licenses/php74-openssl_x509_crl-1.3/LICENSE
        /usr/local/share/licenses/php74-openssl_x509_crl-1.3/MIT
        /usr/local/share/licenses/php74-openssl_x509_crl-1.3/catalog.mk
        /usr/local/share/openssl_x509_crl/ASN1.php
        /usr/local/share/openssl_x509_crl/ASN1_ASCIISTRING.php
        /usr/local/share/openssl_x509_crl/ASN1_BITSTRING.php
        /usr/local/share/openssl_x509_crl/ASN1_BOOL.php
        /usr/local/share/openssl_x509_crl/ASN1_ENUM.php
        /usr/local/share/openssl_x509_crl/ASN1_GENERALTIME.php
        /usr/local/share/openssl_x509_crl/ASN1_INT.php
        /usr/local/share/openssl_x509_crl/ASN1_OCTETSTRING.php
        /usr/local/share/openssl_x509_crl/ASN1_OID.php
        /usr/local/share/openssl_x509_crl/ASN1_SEQUENCE.php
        /usr/local/share/openssl_x509_crl/ASN1_SET.php
        /usr/local/share/openssl_x509_crl/ASN1_SIMPLE.php
        /usr/local/share/openssl_x509_crl/ASN1_TELETEXSTRING.php
        /usr/local/share/openssl_x509_crl/ASN1_UTCTIME.php
        /usr/local/share/openssl_x509_crl/ASN1_UTF8STRING.php
        /usr/local/share/openssl_x509_crl/OID.php
        /usr/local/share/openssl_x509_crl/X509.php
        /usr/local/share/openssl_x509_crl/X509_CERT.php
        /usr/local/share/openssl_x509_crl/X509_CRL.php

This leads to an error and various aspects of certificates breaking:

8:53:45 PHP ERROR: Type: 64, File: /etc/inc/certs.inc, Line: 1006, Message: require_once(): Failed opening required 'ASN1_NULL.php' (include_path='.:/etc/inc:/usr/local/pfSense/include:/usr/local/pfSense/include/www:/usr/local/www:/usr/local/captiveportal:/usr/local/pkg:/usr/local/www/classes:/usr/local/www/classes/Form:/usr/local/share/pear:/usr/local/share/openssl_x509_crl/')

Nothing in the port has changed in years, so there must be some new change either in the build scripts or upstream in the ports repository that results in that file being excluded from the plist. Since the filename contains "NULL" I'm guessing it may be a pattern or regex that is matching too loosely, or getting populated with "NULL" now when it was undefined or had no value in the past.

Actions #1

Updated by Christian McDonald about 2 years ago

  • Assignee changed from Brad Davis to Christian McDonald

Issue caused by some new (undocumented) behavior in upstream pkg.

https://github.com/freebsd/pkg/commit/913c637d65bd4745c79d9ff55af910f603c1b6a6

This commit introduced two new undocumented pkg options ( FILES_IGNORE_REGEX and FILES_IGNORE_GLOB ). Both of these options have incorrect defaults that causes them to match paths that contain the literal string NULL.

Possible solutions:

  1. Add FILES_IGNORE_REGEX [ ] and FILES_IGNORE_GLOB [ ] to our pkg.conf
  2. Fix the incorrect defaults in upstream package so the behavior in #1 above is the default behavior.
Actions #3

Updated by Christian McDonald about 2 years ago

  • % Done changed from 0 to 100
Actions #5

Updated by Christian McDonald about 2 years ago

  • Status changed from Feedback to Resolved

Looks good on latest snapshot

Actions #6

Updated by Jim Pingle about 2 years ago

  • Plus Target Version changed from 22.11 to 23.01
Actions

Also available in: Atom PDF