Project

General

Profile

Actions
Copy link

Bug #13507

closed
MM JP

Copying multiple rules at the same time results in new rules with duplicate tracker IDs

Bug #13507: Copying multiple rules at the same time results in new rules with duplicate tracker IDs

Added by Marcos M almost 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Rules / NAT
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default
Affected Version:
2.7.0
Affected Architecture:

Description

Tested on 22.05 and 22.11.

  1. Select two rules on the LAN
  2. Click the Copy button on the bottom of the page
  3. Select a new interface
  4. Click Paste

Results

anchor "userrules/*" 
pass  in  quick  on $LAN inet from 192.168.1.1/32 to any ridentifier 0100000101 keep state label "USER_RULE: Default allow LAN to any rule" label "id:0100000101" 
pass  in  quick  on $LAN inet from 192.168.1.1/32 to any ridentifier 1663817371 keep state label "USER_RULE: Default allow LAN to any rule" label "id:1663817371" 
pass  in  quick  on $OPT1 inet from 192.168.2.1/32 to any ridentifier 1663817432 keep state label "USER_RULE: Default allow LAN to any rule" label "id:1663817432" 
pass  in  quick  on $OPT1 inet from 192.168.2.1/32 to any ridentifier 1663817432 keep state label "USER_RULE: Default allow LAN to any rule" label "id:1663817432"

Related issues 1 (0 open — 1 closed)

Has duplicate Bug #13518: Firewall Rules get duplicated <rule> <id></id><tracker>1664099550</tracker> after Copy Tracking IDDuplicate

Actions

MM Updated by Marcos M almost 4 years ago Actions
Copy link
 #1

Note: This can lead to the firewall logs showing logs for a different match, e.g. logging a block rule with the description of a pass rule. If possible, the fix should be retroactive.

MM Updated by Marcos M almost 4 years ago Actions
Copy link
 #2

  • Related to Bug #13518: Firewall Rules get duplicated <rule> <id></id><tracker>1664099550</tracker> after Copy Tracking ID added

MM Updated by Marcos M almost 4 years ago Actions
Copy link
 #3

  • Related to deleted (Bug #13518: Firewall Rules get duplicated <rule> <id></id><tracker>1664099550</tracker> after Copy Tracking ID)

MM Updated by Marcos M almost 4 years ago Actions
Copy link
 #4

  • Has duplicate Bug #13518: Firewall Rules get duplicated <rule> <id></id><tracker>1664099550</tracker> after Copy Tracking ID added

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #5

  • Target version set to 2.7.0

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #6

  • Plus Target Version changed from 22.11 to 23.01

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #7

  • Assignee set to Jim Pingle

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #8

  • Status changed from New to In Progress

Looks like a simple fix, it's using microtime inside a loop and it should just be using that once as a starting value and increasing from there.

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #9

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:2e534ffe71dc763c66a2009c07a9883c252afa0f.

AZ Updated by Alhusein Zawi almost 4 years ago Actions
Copy link
 #10

there is no duplication after copy/past the rules.

anchor "userrules/*"
pass in quick on $WAN reply-to ( em0 10.100.100.1 ) inet from any to any ridentifier 1670093227 keep state label "USER_RULE" label "id:1670093227"

pass in quick on $LAN inet proto tcp from 192.168.1.0/24 to any ridentifier 1670108040 flags S/SA keep state label "USER_RULE: test_copy" label "id:1670108040"
pass in quick on $LAN inet proto udp from 192.168.1.1 to any ridentifier 1670108176 keep state label "USER_RULE: test_UDP" label "id:1670108176"
pass in quick on $OPT2 inet proto tcp from 172.18.88.0/24 to any ridentifier 1670108187 flags S/SA keep state label "USER_RULE: test_copy" label "id:1670108187"
pass in quick on $OPT2 inet proto udp from 172.18.88.1 to any ridentifier 1670108188 keep state label "USER_RULE: test_UDP" label "id:1670108188"

23.01-DEVELOPMENT (amd64)
built on Fri Dec 02 06:04:48 UTC 2022

AZ Updated by Alhusein Zawi almost 4 years ago Actions
Copy link
 #11

  • Status changed from Feedback to Resolved

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #12

  • Subject changed from Copying multiple rules at the same time results in new rules with duplicate ridentifiers to Copying multiple rules at the same time results in new rules with duplicate tracker IDs

Updating subject for release notes.

JP Updated by Jim Pingle about 3 years ago Actions
Copy link
 #13

  • Affected Version set to 2.7.0
Actions
Copy link

Also available in: Atom