Project

General

Profile

Actions

Todo #13537

closed

Update vendor files

Added by GChuf 6 almost 2 years ago. Updated 3 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Web Interface
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default

Description

Update jquery and jquery_ui

https://github.com/pfsense/pfsense/pull/4618

Reasons for update:

jquery_ui v1.13.0:
Usage of deprecated jQuery APIs have been removed, 3 security issues fixed, ...
https://blog.jqueryui.com/2021/10/jquery-ui-1-13-0-released/

jquery v3.6.0:
Bug fixes and improvements
https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/

Actions #1

Updated by Marcos M 8 months ago

  • Subject changed from Update jquery and jquery_ui to Update jQuery and fontawesome vendor files
  • Assignee set to Marcos M

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/1098

I tried updating Boostrap as well since there are not supposed to be breaking changes, but some things did break (e.g. "Add Time" button in firewall_schedule_edit.php).

Moving from Beta 3 to our stable v4.x release, there are no breaking changes, but there are some notable changes.

https://getbootstrap.com/docs/4.6/migration/

Actions #2

Updated by Marcos M 8 months ago

  • Subject changed from Update jQuery and fontawesome vendor files to Update vendor files
Actions #3

Updated by Marcos M 8 months ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions #5

Updated by GChuf 6 6 months ago

Hi Marcos,
thanks for taking a look.
I think updating to bootstrap 4 might require a bit more work, definitely needs a new issue/PR.

I see you've taken a look at my other web interface PRs as well - could I ask you to take a look at this one please?
https://redmine.pfsense.org/issues/13520
(Update thermal sensor widget)

I've just force pushed a new version and merged it with master.
I'd love to see this in a future version.
Thanks!

Actions #6

Updated by Jim Pingle 3 months ago

  • Status changed from Feedback to Resolved

There haven't been any noticeable issues with these updated libraries/files in some time now. If any new issues are identified they can be considered separately.

Actions

Also available in: Atom PDF