Todo #13537
closedUpdate vendor files
100%
Description
Update jquery and jquery_ui
https://github.com/pfsense/pfsense/pull/4618
Reasons for update:
jquery_ui v1.13.0:
Usage of deprecated jQuery APIs have been removed, 3 security issues fixed, ...
https://blog.jqueryui.com/2021/10/jquery-ui-1-13-0-released/
jquery v3.6.0:
Bug fixes and improvements
https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/
Files
Related issues
Updated by Marcos M about 1 year ago
- Subject changed from Update jquery and jquery_ui to Update jQuery and fontawesome vendor files
- Assignee set to Marcos M
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/1098
- nvd3 updated to 1.8.6
- fontawesome updated to 6.4.2
- jQuery-ui updated to 1.13.2
- jQuery updated to 3.7.1:
We do not expect compatibility issues when upgrading from a jQuery 3.0+ version.
https://blog.jquery.com/2023/08/28/jquery-3-7-1-released-reliable-table-row-dimensions/
I tried updating Boostrap as well since there are not supposed to be breaking changes, but some things did break (e.g. "Add Time" button in firewall_schedule_edit.php
).
Moving from Beta 3 to our stable v4.x release, there are no breaking changes, but there are some notable changes.
Updated by Marcos M about 1 year ago
- Subject changed from Update jQuery and fontawesome vendor files to Update vendor files
Updated by Marcos M about 1 year ago
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
Applied in changeset b18653a30eb4fa5d33ded0a78c7ddba0043f0e0c.
Updated by Marcos M about 1 year ago
- Target version set to 2.8.0
- Plus Target Version set to 24.03
Updated by GChuf 6 11 months ago
Hi Marcos,
thanks for taking a look.
I think updating to bootstrap 4 might require a bit more work, definitely needs a new issue/PR.
I see you've taken a look at my other web interface PRs as well - could I ask you to take a look at this one please?
https://redmine.pfsense.org/issues/13520
(Update thermal sensor widget)
I've just force pushed a new version and merged it with master.
I'd love to see this in a future version.
Thanks!
Updated by Jim Pingle 8 months ago
- Status changed from Feedback to Resolved
There haven't been any noticeable issues with these updated libraries/files in some time now. If any new issues are identified they can be considered separately.
Updated by Jim Pingle about 2 months ago
It might be something to look at in the future, but it would have to be pulled in directly from an upstream source and match their hashes and so on, so not a good candidate for a PR since it's harder to audit that way. That would be for a separate Redmine, this one is already closed.
Updated by Marcos M about 2 months ago
- Has duplicate Todo #14190: Update nvd3 (web ui dependency) to 1.8.6 added