Project

General

Profile

Actions
Copy link

Todo #13537

closed

Update vendor files

Added by GChuf 6 about 2 years ago. Updated 2 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Marcos M
Category:
Web Interface
Target version:
2.8.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default

Description

Update jquery and jquery_ui

https://github.com/pfsense/pfsense/pull/4618

Reasons for update:

jquery_ui v1.13.0:
Usage of deprecated jQuery APIs have been removed, 3 security issues fixed, ...
https://blog.jqueryui.com/2021/10/jquery-ui-1-13-0-released/

jquery v3.6.0:
Bug fixes and improvements
https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/

Files

nvd3.png (58.3 KB) nvd3.png GChuf 6, 10/12/2024 08:34 PM

Related issues

Has duplicate Todo #14190: Update nvd3 (web ui dependency) to 1.8.6Duplicate

Actions
Actions
Copy link
 #1

Updated by Marcos M about 1 year ago

  • Subject changed from Update jquery and jquery_ui to Update jQuery and fontawesome vendor files
  • Assignee set to Marcos M

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/1098

I tried updating Boostrap as well since there are not supposed to be breaking changes, but some things did break (e.g. "Add Time" button in firewall_schedule_edit.php).

Moving from Beta 3 to our stable v4.x release, there are no breaking changes, but there are some notable changes.

https://getbootstrap.com/docs/4.6/migration/

Actions
Copy link
 #2

Updated by Marcos M about 1 year ago

  • Subject changed from Update jQuery and fontawesome vendor files to Update vendor files
Actions
Copy link
 #3

Updated by Marcos M about 1 year ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by GChuf 6 12 months ago

Hi Marcos,
thanks for taking a look.
I think updating to bootstrap 4 might require a bit more work, definitely needs a new issue/PR.

I see you've taken a look at my other web interface PRs as well - could I ask you to take a look at this one please?
https://redmine.pfsense.org/issues/13520
(Update thermal sensor widget)

I've just force pushed a new version and merged it with master.
I'd love to see this in a future version.
Thanks!

Actions
Copy link
 #6

Updated by Jim Pingle 9 months ago

  • Status changed from Feedback to Resolved

There haven't been any noticeable issues with these updated libraries/files in some time now. If any new issues are identified they can be considered separately.

Actions
Copy link
 #7

Updated by GChuf 6 2 months ago

Would you consider replacing nv.d3.js file with a minified version?
Currently, on my dashboard, this is the biggest file:


This would bring some performance improvements on clients as well as faster first loads.

Actions
Copy link
 #8

Updated by Jim Pingle 2 months ago

It might be something to look at in the future, but it would have to be pulled in directly from an upstream source and match their hashes and so on, so not a good candidate for a PR since it's harder to audit that way. That would be for a separate Redmine, this one is already closed.

Actions
Copy link
 #9

Updated by Marcos M 2 months ago

  • Has duplicate Todo #14190: Update nvd3 (web ui dependency) to 1.8.6 added
Actions
Copy link

Also available in: Atom PDF