Todo #13537
closed
- Subject changed from Update jquery and jquery_ui to Update jQuery and fontawesome vendor files
- Assignee set to Marcos M
- Subject changed from Update jQuery and fontawesome vendor files to Update vendor files
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
- Target version set to 2.8.0
- Plus Target Version set to 24.03
Fontawesome icon names updated in CE/Plus:
Hi Marcos,
thanks for taking a look.
I think updating to bootstrap 4 might require a bit more work, definitely needs a new issue/PR.
I see you've taken a look at my other web interface PRs as well - could I ask you to take a look at this one please?
https://redmine.pfsense.org/issues/13520
(Update thermal sensor widget)
I've just force pushed a new version and merged it with master.
I'd love to see this in a future version.
Thanks!
- Status changed from Feedback to Resolved
There haven't been any noticeable issues with these updated libraries/files in some time now. If any new issues are identified they can be considered separately.
Would you consider replacing nv.d3.js file with a minified version?
Currently, on my dashboard, this is the biggest file:
This would bring some performance improvements on clients as well as faster first loads.
It might be something to look at in the future, but it would have to be pulled in directly from an upstream source and match their hashes and so on, so not a good candidate for a PR since it's harder to audit that way. That would be for a separate Redmine, this one is already closed.
- Has duplicate Todo #14190: Update nvd3 (web ui dependency) to 1.8.6 added
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by