Project

General

Profile

Actions
Copy link

Regression #13553

closed
KT CM

Feature #13446: Upgrade PHP from 7.4 to 8.1

PHP error when creating a new limiter

Regression #13553: PHP error when creating a new limiter

Added by Keith Townsend almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Christian McDonald
Category:
Traffic Shaper (Limiters)
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Force Exclusion
Affected Version:
2.7.x
Affected Architecture:

Description

Adding a new Limiter to Firewall>Traffic Shaper>Limiters results in a PHP Error/Crash

2.7 Developer snapshot

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #1

  • Subject changed from PHP Errors/Crash to PHP error when creating a new limiter
  • Category changed from PHP Interpreter to Traffic Shaper (Limiters)
  • Status changed from New to Confirmed
  • Target version set to 2.7.0
  • Plus Target Version set to 22.11
  • Release Notes changed from Default to Force Exclusion
[11-Oct-2022 12:38:44 Etc/UTC] PHP Fatal error:  Uncaught TypeError: ceil(): Argument #1 ($num) must be of type int|float, string given in /etc/inc/shaper.inc:4370
Stack trace:
#0 /etc/inc/shaper.inc(4370): ceil('')
#1 /etc/inc/shaper.inc(4473): dnpipe_class->build_bwtable()
#2 /usr/local/www/firewall_shaper_vinterface.php(147): dnpipe_class->build_form()
#3 {main}
  thrown in /etc/inc/shaper.inc on line 4370

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #3

  • Plus Target Version changed from 22.11 to 23.01

DZ Updated by Danilo Zrenjanin almost 4 years ago Actions
Copy link
 #4

Tested:

2.7.0-DEVELOPMENT (amd64)
built on Fri Oct 14 06:04:12 UTC 2022
FreeBSD 14.0-CURRENT

I was able to make limiters with no PHP errors. The fix has not been implemented in the version I tested. If there are any specific setups to replicate it, please point them out.

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #5

  • Status changed from Feedback to Closed
  • Assignee set to Christian McDonald
  • % Done changed from 0 to 100

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #6

  • Parent task set to #13446

JP Updated by Jim Pingle almost 4 years ago Actions
Copy link
 #7

  • Tracker changed from Bug to Regression

JP Updated by Jim Pingle over 3 years ago Actions
Copy link
 #8

  • Status changed from Closed to Resolved
Actions
Copy link

Also available in: Atom