Home
Projects
Help

Search:

pfSense

All Projects

pfSense

Overview
Activity
Roadmap
Issues
Gantt
Calendar
News
Documents
Repository

Custom queries

2.4.5-p1 - Resolved/Closed
2.5.0 - Resolved/Closed
2.5.1 - Resolved/Closed
2.5.2 - Resolved/Closed
2.6.0 - Resolved/Closed
2.7.0 - Resolved/Closed
2.7.1 - All Open Issues
2.7.1 - Resolved/Closed
2.7.2 - Resolved/Closed
2.8.0 - All Open Bugs
2.8.0 - All Open Features
2.8.0 - All Open Issues
2.8.0 - All Open Regressions
2.8.0 - Feedback
2.8.0 - Needs Attention
2.8.0 - New/Confirmed
2.8.0 - Pull Requests
2.8.0 - Regressions affecting 2.7.0
2.8.0 - Resolved/Closed
21.02.2/2.5.1 - Resolved/Closed
21.05 Plus - All Closed Issues
21.05.1 Plus Target - All Closed Issues
21.05.1 Target - All Closed Issues
22.01 Plus - All Closed Issues
22.01 Target - All Closed Issues
22.05 Plus - All Closed Issues
22.05 Target - All Closed Issues
23.01 Plus - All Closed Issues
23.01 Target - All Closed Issues
23.05 Plus - All Closed Issues
23.05 Target - All Closed Issues
23.05.1 Plus - All Closed Issues
23.05.1 Target - All Closed Issues
23.09 Plus - All Closed Issues
23.09 Target - All Closed Issues
23.09.1 Plus - All Closed Issues
23.09.1 Target - All Closed Issues
24.03 Plus - All Closed Issues
24.03 Target - All Closed Issues
24.11 Plus - All Closed Issues
24.11 Plus - All Open Issues
24.11 Plus - Feedback Issues
24.11 Plus - Needs Attention/Work
24.11 Plus - New/Confirmed/In Progress Issues
24.11 Target - All Closed Issues
24.11 Target - All Open Issues
25.01 Plus - All Closed Issues
25.01 Plus - All Open Issues
25.01 Plus - Feedback Issues
25.01 Plus - Needs Attention/Work
25.01 Plus - New/Confirmed/In Progress Issues
25.01 Plus - Pull Request Review
25.01 Plus - Waiting on Merge
25.01 Target - All Closed Issues
25.01 Target - All Open Issues
All Open Issues assigned to Me
All Open Pull Requests
Any Target - All Open Regressions
Any Target - Feedback Issues
CE-Next - All Closed Issues (Move to specific target)
CE-Next - All Open Issues
CE-Next - Feedback (Likely needs target changed)
New Issues by Category - Future Target
New Issues by Category - No Target
New Issues by Category - No Target+Future
No Target - All Open Issues (Base Only)
No Target - New Issues (Base Only)
No Target - New Issues (Base and Packages)
Release Notes - Plus Target Version (DO NOT EDIT)
Release Notes - Target Version (DO NOT EDIT)

Actions

Copy link

Bug #13755

closed

Multiple incorrect configuration paths in recent UPnP code changes

Added by Marcos M almost 2 years ago. Updated almost 2 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jim Pingle

Category:

UPnP/NAT-PMP

Target version:

2.7.0

Start date:

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

23.01

Release Notes:

Force Exclusion

Affected Version:

Affected Architecture:

Description

The automatic rule pass multicast traffic to miniupnpd is never created.

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Marcos M almost 2 years ago

The miniupnp auto rule has been broken since the code was committed due to the invalid config path access, and due to the protocol being tcp instead of udp. The default allow rule already passes the traffic, hence simply remove the broken code.

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/979

Actions

Copy link

Updated by Marcos M almost 2 years ago

Status changed from New to Pull Request Review

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Assignee changed from Marcos M to Jim Pingle

There is at least one other place using the same incorrect test for upnp being enabled, and I'd prefer a slightly different approach to fixing the rules than the one in the PR. I'll take care of these.

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Subject changed from Automatic rules for miniupnp are not created. to Multiple incorrect configuration paths in recent UPnP code changes

I spotted another incorrect configuration path usage in there as well as I was testing. Commit coming shortly.

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Status changed from Pull Request Review to Feedback
% Done changed from 0 to 100

Applied in changeset 374dd9fe6a456d09cb41515b913396ac0992467d.

Actions

Copy link

Updated by Jim Pingle almost 2 years ago

Status changed from Feedback to Resolved

All working well on current snapshots:

No trace of UPnP anchors/rules in ruleset when UPnP is disabled
Enabling UPnP starts the service and reloads the ruleset
UPnP anchors/rules are present after enabling UPnP
When disabling UPnP, the service is stopped and the rules are reloaded, removing all traces again
At boot, the message saying UPnP is starting only prints when UPnP is enabled.

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

pfSense

Custom queries

Bug #13755

Multiple incorrect configuration paths in recent UPnP code changes

Updated by Marcos M almost 2 years ago

Updated by Marcos M almost 2 years ago

Updated by Jim Pingle almost 2 years ago

Updated by Jim Pingle almost 2 years ago

Updated by Jim Pingle almost 2 years ago

Updated by Jim Pingle almost 2 years ago