Bug #13798
closed
Crash report with lldpd package and 23.01.b.20221223.0600
Added by Richie Crews over 1 year ago.
Updated over 1 year ago.
Affected Plus Version:
23.01
Affected Architecture:
All
Description
Seen this issue since the first 23.01 BETA and still see it every upgrade. Using the standard LLDPD package from pfSense.
Crash report begins. Anonymous machine information:
amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-devel-main-n255997-353da694fe8: Fri Dec 23 06:28:48 UTC 2022 root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-master-main/obj/amd64/CrayRXyk/var/jenkins/workspace/pfSense-Plus-snapshots-master-main/sources/FreeBS
Crash report details:
PHP Errors:
[24-Dec-2022 17:56:03 America/New_York] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/lldpd/lldpd.inc:43
Stack trace:
#0 /etc/inc/pkg-utils.inc(715) : eval()'d code(1): lldpd_sync_config()
#1 /etc/inc/pkg-utils.inc(715): eval()
#2 /etc/rc.start_packages(66): sync_package('lldpd')
#3 {main}
thrown in /usr/local/pkg/lldpd/lldpd.inc on line 43
No FreeBSD crash data found.
I'm unable to reproduce any issue with the LLPDd package in pfSense 23.01-BETA's December 28th build. Please provide exact step-by-step instructions for how you were able to reproduce this PHP crash, as I don't see anything wrong.
Things tested:
1. Went to Services --> LLDP and enabled the service. Service started normally.
2. Navigated to both the LLDP Status and Setting menus without issue
3. Tried enabling and disabling all of the various Protocol Support and General Settings
All of these pages loaded normally and without any crashes or issues.
- Release Notes deleted (
Default)
- Project changed from pfSense Plus to pfSense Packages
- Category changed from Package System to lldpd
- Assignee set to Jim Pingle
The error in the original report is definitely from problematic code when run under PHP 8.1. It would be most evident when starting from a fresh install, though it might also be easier to trigger if the package settings are removed somehow without uninstalling/reinstalling the package.
$lldpd_config = &$config['installedpackages']['lldpd']['config'][0];
The code needs a once-over for that and other PHP 8.1 issues.
- Status changed from New to Feedback
- % Done changed from 0 to 100
- Affected Version set to 2.7.0
- Affected Architecture All added
- Affected Architecture deleted (
amd64)
- Status changed from Feedback to Resolved
Also available in: Atom
PDF
Updated by 
Updated by