Project

General

Profile

Actions

Bug #13915

closed

PHP errors when re-running Traffic Shaper Wizards with different settings

Added by Athanasios Chatzi over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Traffic Shaper Wizards
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.05
Release Notes:
Default
Affected Version:
2.7.0
Affected Architecture:
amd64

Description

While finishing the configuration of traffic shaper at apply configuration appeared the error


Files

PHP_errors.log (510 Bytes) PHP_errors.log Athanasios Chatzi, 01/29/2023 04:31 AM
clipboard-202301301532-malze.png (199 KB) clipboard-202301301532-malze.png Athanasios Chatzi, 01/30/2023 07:32 AM
clipboard-202301301533-6pylu.png (127 KB) clipboard-202301301533-6pylu.png Athanasios Chatzi, 01/30/2023 07:33 AM
clipboard-202301301534-eushw.png (109 KB) clipboard-202301301534-eushw.png Athanasios Chatzi, 01/30/2023 07:34 AM
clipboard-202301301534-fwkri.png (54.6 KB) clipboard-202301301534-fwkri.png Athanasios Chatzi, 01/30/2023 07:34 AM
clipboard-202301301535-fs8ko.png (108 KB) clipboard-202301301535-fs8ko.png Athanasios Chatzi, 01/30/2023 07:35 AM
clipboard-202301301535-z5mhi.png (117 KB) clipboard-202301301535-z5mhi.png Athanasios Chatzi, 01/30/2023 07:35 AM
clipboard-202301301536-ltnqw.png (107 KB) clipboard-202301301536-ltnqw.png Athanasios Chatzi, 01/30/2023 07:36 AM
clipboard-202302041248-eegkc.png (60.3 KB) clipboard-202302041248-eegkc.png Error when click "finish" in the wizard Humberto Nieto, 02/04/2023 05:48 AM
PHP_errors (2).log (1020 Bytes) PHP_errors (2).log crash log Humberto Nieto, 02/04/2023 05:49 AM

Related issues

Has duplicate Bug #14303: Error when trying to setup traffic shapingDuplicate

Actions
Actions #1

Updated by Jim Pingle over 1 year ago

Can you attach the <ezshaper>[...]</ezshaper> section from your configuration and give us a list of all the options you used when stepping through the wizard?

Actions #2

Updated by Athanasios Chatzi over 1 year ago

Jim Pingle wrote in #note-1:

Can you attach the <ezshaper>[...]</ezshaper> section from your configuration and give us a list of all the options you used when stepping through the wizard?

Hi Jim , i cannot replicate the error.
therefore those are the options that i've checked,

Actions #3

Updated by Athanasios Chatzi over 1 year ago

Athanasios Chatzi wrote in #note-2:

Jim Pingle wrote in #note-1:

Can you attach the <ezshaper>[...]</ezshaper> section from your configuration and give us a list of all the options you used when stepping through the wizard?

Hi Jim , i cannot replicate the error.
therefore those are the options that i've checked,






<ezshaper>
<step1>
<numberofconnections>4</numberofconnections>
<numberoflocalinterfaces>2</numberoflocalinterfaces>
</step1>
<step5>
<enable>on</enable>
<p2pcatchall>on</p2pcatchall>
<bandwidth>15</bandwidth>
<bandwidthunit>%</bandwidthunit>
<bittorrent>on</bittorrent>
<aimster>on</aimster>
<buddyshare>on</buddyshare>
<cutemx>on</cutemx>
<dcplusplus>on</dcplusplus>
<dcc>on</dcc>
<directconnect>on</directconnect>
<directfileexpress>on</directfileexpress>
<edonkey2000>on</edonkey2000>
<fasttrack>on</fasttrack>
<gnutella>on</gnutella>
<grouper>on</grouper>
<hotcomm>on</hotcomm>
<hotlineconnect>on</hotlineconnect>
<imesh>on</imesh>
<napster>on</napster>
<opennap>on</opennap>
<scour>on</scour>
<shareaza>on</shareaza>
<songspy>on</songspy>
<winmx>on</winmx>
</step5>
<step6>
<enable>on</enable>
<battlenet>on</battlenet>
<eaorigin>on</eaorigin>
<steam>on</steam>
<eveonline>on</eveonline>
</step6>
<step7>
<enable>on</enable>
<appleremotedesktop>L</appleremotedesktop>
<msrdp>H</msrdp>
<pcanywhere>L</pcanywhere>
<vnc>L</vnc>
<aolinstantmessenger>L</aolinstantmessenger>
<facetime>L</facetime>
<icq>L</icq>
<irc>L</irc>
<jabber>L</jabber>
<googlehangouts>L</googlehangouts>
<msnmessenger>L</msnmessenger>
<teamspeak>L</teamspeak>
<teamspeak3>L</teamspeak3>
<ventrilo>L</ventrilo>
<pptp>L</pptp>
<ipsec>H</ipsec>
<itunesradio>L</itunesradio>
<streamingmp3>H</streamingmp3>
<rtsp>H</rtsp>
<rtmp>H</rtmp>
<http>D</http>
<smtp>L</smtp>
<pop3>L</pop3>
<imap>L</imap>
<lotusnotes>L</lotusnotes>
<battlenetdownloader>D</battlenetdownloader>
<steamdownloader>D</steamdownloader>
<apns>D</apns>
<applemobilesync>L</applemobilesync>
<crashplan>L</crashplan>
<cvsup>L</cvsup>
<dns>H</dns>
<git>L</git>
<hbci>L</hbci>
<icmp>D</icmp>
<smb>H</smb>
<snmp>L</snmp>
<mysqlserver>L</mysqlserver>
<nntp>D</nntp>
<slingbox>L</slingbox>
<subversion>L</subversion>
</step7>
<step2>
<local0downloadscheduler>PRIQ</local0downloadscheduler>
<local0interface>lan</local0interface>
<local1downloadscheduler>PRIQ</local1downloadscheduler>
<local1interface>opt4</local1interface>
<conn0uploadscheduler>PRIQ</conn0uploadscheduler>
<conn0upload>50</conn0upload>
<conn0uploadspeed>Mb</conn0uploadspeed>
<conn0download>150</conn0download>
<conn0downloadspeed>Mb</conn0downloadspeed>
<conn0interface>wan</conn0interface>
<conn1uploadscheduler>PRIQ</conn1uploadscheduler>
<conn1upload>10</conn1upload>
<conn1uploadspeed>Mb</conn1uploadspeed>
<conn1download>100</conn1download>
<conn1downloadspeed>Mb</conn1downloadspeed>
<conn1interface>opt1</conn1interface>
<conn2uploadscheduler>PRIQ</conn2uploadscheduler>
<conn2upload>10</conn2upload>
<conn2uploadspeed>Mb</conn2uploadspeed>
<conn2download>100</conn2download>
<conn2downloadspeed>Mb</conn2downloadspeed>
<conn2interface>opt3</conn2interface>
<conn3uploadscheduler>PRIQ</conn3uploadscheduler>
<conn3upload>5</conn3upload>
<conn3uploadspeed>Mb</conn3uploadspeed>
<conn3download>50</conn3download>
<conn3downloadspeed>Mb</conn3downloadspeed>
<conn3interface>opt2</conn3interface>
</step2>
</ezshaper>

Actions #4

Updated by Humberto Nieto over 1 year ago

Hi all!

Same problem here!! Since i updated to 23.01-RC i have the same problem like you.

I always had it working through the wizard and after updating it gives me that PHP error. (PFblockerng also failed me and I had to uninstall it, it didn't update and it hung in the CRON process)

I attach screenshots and my log

Error when click finish in the wizard

Thanks, regards!

Actions #5

Updated by Athanasios Chatzi over 1 year ago

Athanasios Chatzi wrote in #note-2:

Jim Pingle wrote in #note-1:

Can you attach the <ezshaper>[...]</ezshaper> section from your configuration and give us a list of all the options you used when stepping through the wizard?

Hi Jim , i cannot replicate the error.
therefore those are the options that i've checked,

I manage to replicate the issue. When I'm trying to remove a previous rule , for instance, prioritize network gaming rule , it's crashing.
If I do not and change other rules does not.

Actions #6

Updated by Jim Pingle over 1 year ago

  • Project changed from pfSense Plus to pfSense
  • Subject changed from Error while trying to configure traffic shaper to PHP error when making changes in the traffic shaper wizard
  • Category changed from Unknown to Traffic Shaper Wizards
  • Target version set to 2.7.0
  • Affected Plus Version deleted (23.01)
  • Plus Target Version set to 23.05
Actions #7

Updated by Drew Saur over 1 year ago

If I can be of help, please let me know. I am having this issue as well, consistently. See https://forum.netgate.com/topic/177994/traffic-shaping-in-23-01-bug/.

Actions #8

Updated by Stefan Weichinger over 1 year ago

I also "volunteer" to test something.

Actions #9

Updated by Jim Pingle about 1 year ago

  • Has duplicate Bug #14303: Error when trying to setup traffic shaping added
Actions #10

Updated by Jim Pingle about 1 year ago

There are also similar errors in the dedicated links shaper wizard, not just the multiple lan/wan wizard. See duplicate report #14303 for a slight variation on this error.

Actions #11

Updated by David Askew about 1 year ago

Also getting the same issue with a slight variation of the error.

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc:717 Stack trace: #0 /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc(626): apply_all_chosen_items() #1 /usr/local/www/wizard.php(116) : eval()'d code(1): step8_stepsubmitphpaction() #2 /usr/local/www/wizard.php(116): eval() #3 {main} thrown in /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc on line 717 PHP ERROR: Type: 1, File: /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc, Line: 717, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc:717 Stack trace: #0 /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc(626): apply_all_chosen_items() #1 /usr/local/www/wizard.php(116) : eval()'d code(1): step8_stepsubmitphpaction() #2 /usr/local/www/wizard.php(116): eval() #3 {main} thrown

I think @Jim Pingle meant to link to my duplicate post above but linked back to this one. My duplicate post is:
https://redmine.pfsense.org/issues/14303

Please release an fix and don't make us wait for the next release if possible? I personally really need this urgently.

Actions #12

Updated by Steve Y about 1 year ago

Looking at the code (traffic_shaper_wizard_multi_all.inc:773) and nearby if tests the various step numbers use:

if ($config['ezshaper']['step3']['enable']) {

Per https://docs.netgate.com/pfsense/en/latest/development/php-config-arrays.html#examples that's the old PHP 7 style. Seems like the shaper code just needs updating to the new coding format.

Actions #13

Updated by Drew Saur about 1 year ago

Thank you for whatever you can do - I hope this makes it into a Patch update soon, because I miss this feature dearly.

Actions #14

Updated by Jim Pingle about 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Jim Pingle
Actions #15

Updated by Jim Pingle about 1 year ago

  • % Done changed from 0 to 50

I just pushed 1c6665b003bc7ac9a7c558e5d93aa2f0dd774c18 which will show up shortly. It addresses the PHP issues in the multi-all wizard. I'm still working on the dedicated links wizard.

Actions #16

Updated by Jim Pingle about 1 year ago

  • Status changed from In Progress to Feedback
  • % Done changed from 50 to 100

c966d0cc68fde98c305ea48aee14c254b8cd207a addresses issues in the dedicated links wizard.

I did some light testing of both and I see the kinds of rules I expect to see, and going through the wizard multiple times and enabling/disabling sections differently in each run works.

Will let this soak in snapshots over the weekend and if things are OK I'll look into adding it to the system patches package.

Actions #17

Updated by Stefan Weichinger about 1 year ago

Jim Pingle wrote in #note-16:

Will let this soak in snapshots over the weekend and if things are OK I'll look into adding it to the system patches package.

Sounds great, thanks for your work. Looking forward to the patch.

Actions #18

Updated by Jim Pingle about 1 year ago

  • Status changed from Feedback to In Progress
  • % Done changed from 100 to 90

Reviewing the files again this morning I spotted a couple potential problems still, will have a follow-up commit coming later today.

Actions #19

Updated by Jim Pingle about 1 year ago

  • Status changed from In Progress to Feedback
  • % Done changed from 90 to 100
Actions #20

Updated by Jim Pingle about 1 year ago

  • Subject changed from PHP error when making changes in the traffic shaper wizard to PHP errors when re-running Traffic Shaper Wizards with different settings

Updating subject for release notes.

Actions #21

Updated by Jordan G about 1 year ago

not seeing any php errors so far when utilizing the traffic shaping wizard or manipulating bandwidth settings after initial run in 23.05.b.20230428.2019

Actions #22

Updated by Jim Pingle about 1 year ago

  • Status changed from Feedback to Resolved
Actions #23

Updated by Jim Pingle about 1 year ago

  • Affected Version set to 2.7.0
Actions

Also available in: Atom PDF