pfSense

I couldn't reproduce the issue on the:

23.01-RELEASE (amd64)
built on Fri Feb 10 20:06:33 UTC 2023
FreeBSD 14.0-CURRENT

I made an extensive list of aliases that were getting sorted by name alphabetically after saving. Can you provide an example to test?

Danilo Zrenjanin wrote in #note-3:

I couldn't reproduce the issue on the:
I made an extensive list of aliases that were getting sorted by name alphabetically after saving. Can you provide an example to test?

Not yet, I'm just basing this off a report on the forum. I have not reproduced it yet nor attempted to fix it, that's why I marked it back as "in progress". It also works fine for me when I tried it on a couple different systems last night, but I'll see what I can come up with today yet.

This was also broken again by 29cd08ea0da6246ad416e33b3788c05c0b0a5172 during a rector pass. It was changed back to asort and the sort-on-save part was lost in that change. We can't rely on asort because it's only case sensitive so it sorts them out of order if there are aliases that start with both upper and lower case letters, and there isn't a flag to pass to asort which makes it case insensitive that I see.

There is SORT_FLAG_CASE but it doesn't actually work as expected here, on its own or combined with others, such as SORT_STRING | SORT_FLAG_CASE | SORT_NATURAL, it still sorts either all the uppercase first or all the uppercase last.

Also of note: I added another patch to the system patches package which applies on top of the previous patch (4342d179afe732baf3a73e2db4381b57b1aa7703) so a user can apply both to get the new behavior on 23.01 since the code on 23.05 diverged too much to apply the new commit directly.

diff --git a/src/usr/local/www/firewall_aliases.php b/src/usr/local/www/firewall_aliases.php
index 52c2c28503..8c2c2a832d 100644
--- a/src/usr/local/www/firewall_aliases.php
+++ b/src/usr/local/www/firewall_aliases.php
@@ -114,7 +114,8 @@ display_top_tabs($tab_array);
     </thead>
     <tbody>
 <?php
-    foreach (msort($a_aliases, 'name') as $i => $alias):
+    uasort($a_aliases, function ($a, $b) { return strnatcasecmp($a['name'], $b['name']); });
+    foreach ($a_aliases as $i => $alias):
         unset ($show_alias);
         switch ($tab) {
         case "all":

The other changes in the commit that fixed this aren't relevant on 23.01.