Project

General

Profile

Actions

Bug #14484

closed

lldpd php error on saving with no interface selected

Added by Jordan G 11 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
lldpd
Target version:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
Affected Plus Version:
23.05
Affected Architecture:
All

Description

use ctrl + click and deselect any interface (previously) highlighted and attempt to save lldpd settings

Fatal error: Uncaught TypeError: implode(): Argument #1 ($pieces) must be of type array, string given in /usr/local/www/lldpd_settings.php:44 Stack trace: #0 /usr/local/www/lldpd_settings.php(44): implode(',', NULL) #1 {main} thrown in /usr/local/www/lldpd_settings.php on line 44 PHP ERROR: Type: 1, File: /usr/local/www/lldpd_settings.php, Line: 44, Message: Uncaught TypeError: implode(): Argument #1 ($pieces) must be of type array, string given in /usr/local/www/lldpd_settings.php:44 Stack trace: #0 /usr/local/www/lldpd_settings.php(44): implode(',', NULL) #1 {main} thrown
PHP ERROR: Type: 1, File: /usr/local/www/lldpd_settings.php, Line: 44, Message: Uncaught TypeError: implode(): Argument #1 ($pieces) must be of type array, string given in /usr/local/www/lldpd_settings.php:44
Stack trace:
#0 /usr/local/www/lldpd_settings.php(44): implode(',', NULL)
#1 {main}

Files

clipboard-202307291527-yekks.png (15.8 KB) clipboard-202307291527-yekks.png aleksei prokofiev, 07/29/2023 12:27 PM
Actions #1

Updated by Jim Pingle 11 months ago

  • Plus Target Version deleted (23.05.1)
Actions #2

Updated by Lev Prokofev 9 months ago

I can reproduce it on 23.05.1, probably the "No interface selected" warning message is needed here.

PHP ERROR: Type: 1, File: /usr/local/www/lldpd_settings.php, Line: 44, Message: Uncaught TypeError: implode(): Argument #1 ($pieces) must be of type array, string given in /usr/local/www/lldpd_settings.php:44
Stack trace:
#0 /usr/local/www/lldpd_settings.php(44): implode(',', NULL)
#1 {main}
  thrown
Actions #3

Updated by Lev Prokofev 9 months ago

  • Status changed from New to Confirmed
Actions #4

Updated by Jim Pingle 9 months ago

  • Assignee set to Jim Pingle
Actions #5

Updated by Jim Pingle 9 months ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

I pushed a fix, it is building now and will be available shortly in lldpd pkg version 0.9.11_2 on Plus 23.05.1 and CE 2.7.0, and dev snapshots whenever the next build happens.

Actions #6

Updated by aleksei prokofiev 9 months ago

Tested on 23.05.1 and 2.7.0

lldpd 0.9.11_2    

looks fine, the warning message is presented

Actions #7

Updated by Jordan G 9 months ago

confirmed, now working with lldpd 0.9.11_2

Actions #8

Updated by Jim Pingle 9 months ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF