pfSense

Created a forum topic just in case: https://forum.netgate.com/topic/181150/bug-in-gateway-group-creation-screen

I made a small patch against the current stable (CE) repository.

Problem most certainly stems from util.inc (https://github.com/pfsense/pfsense/blob/master/src/etc/inc/util.inc) and will thus be present in either CE and Plus versions.

I think I identified the problem in build_vip_list() or better said in the selection of get_configured_vip_list() below the list function. The problem seems to stem from get_configured_vip_interface which calls get_configured_vip_detail which should reporting back the correct interface (WAN, etc). But for the Alias-on-CARP it reports the uniqid of the parent VIP (_vip<ID>) so the IF clause in function build_vip_list() filters it out - wrongly so - instead of checking the parent for selection.

I did a small quick an dirty patch to circumvent that with an additional "else"-clause in build_vip_list():

function build_vip_list($fif, $family = "all") {
        $list = array('address' => gettext('Interface Address'));

        $viplist = get_configured_vip_list($family);
        foreach ($viplist as $vip => $address) {
                if ($fif == get_configured_vip_interface($vip)) {
                        $list[$vip] = "$address";
                        if (get_vip_descr($address)) {
                                $list[$vip] .= " (". get_vip_descr($address) .")";
                        }
                }
                else { // MODIFICATION START
                        // only check Alias VIPs on CARP that return _vip* instead of an interface description
                        $parentif = get_configured_vip_interface($vip);
                        if (str_starts_with($parentif, "_vip")) {
                                if ($fif == get_configured_vip_interface($parentif)) {
                                        $list[$vip] = "$address";
                                        if (get_vip_descr($address)) {
                                                $list[$vip] .= " (". get_vip_descr($address) .")";
                                        }
                                }
                        }
                } // MODIFICATION END
        }

        return($list);
}

My clause only triggers, if the return value of the run is a String that starts with "_vip" thus indicating, that it is a "alias-on-carp" situation, as other VIPs are already filtered out by not being able to have VIPs (so no "other" and "Proxy ARP" types are present). So if the return value doesn't match the "$fif" (friendly interface name) it's checked once again, if it returns a "_vip<ID>" type string and this string is checked again for its parent. If the parent then matches the $fif before, then it's listed in the dropdown, otherwise the filter cuts it out. Perhaps there's a finer solution ;) but this seems to work right now in my lab environment, letting me select the needed Alias VIP and saving it correctly in the corresponding gateway group with the correct identifier.

Would also provide a pull request if needed!

Cheers
\jens

Just wanted to add that the fix is working in a production setting on a customer's box running with multiple VIPs and updating DynDNS names according to the configured failover groups without a hitch. hopefully this can either be integrated or somehow incorporated in a "better"/cleaner way?

Will gladly try to send that in as a pull tomorrow.

Created as Pull request https://github.com/pfsense/pfsense/pull/4646