Project

General

Profile

Actions

Bug #14571

closed

PHP Error prevents LCDProc client from working properly due to empty VIP tags in config.xml

Added by Cino . 10 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
LCDProc
Target version:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
2.7.0
Affected Plus Version:
Affected Architecture:

Description

Since the latest pfSense update, the LCDproc client is unable to connect to the LCDproc server. I can confirm LCDproc is running and controlling the display but the php client isn't connecting. I believe its due to the php update within pfsense itself

PHP ERROR: Type: 1, File: /usr/local/pkg/lcdproc_client.php, Line: 461, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/lcdproc_client.php:461
Stack trace:
#0 /usr/local/pkg/lcdproc_client.php(1146): outputled_carp()
#1 /usr/local/pkg/lcdproc_client.php(1403): loop_status(Resource id #47)
#2 {main}


Files

PHP_errors.log (1.86 KB) PHP_errors.log Cino ., 07/12/2023 02:47 PM
Actions #1

Updated by Jim Pingle 10 months ago

  • Assignee set to Jim Pingle
Actions #2

Updated by Jim Pingle 10 months ago

  • Subject changed from The LCDproc client isn't connecting to LCDproc server to PHP Error prevents LCDProc client from working properly due to empty VIP tags in config.xml
  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Fixed in the new version of the package I just committed. Will be available once the package builds finish.

Actions #3

Updated by Steve Wheeler 10 months ago

Seeing some errors when trying to use the Reboot or Shutdown functions from the LCD buttons:

Jul 13 22:04:29     php     46723     lcdproc: init REBOOT!
Jul 13 22:04:30     php     46723     /usr/local/pkg/lcdproc_client.php: PHP ERROR: Type: 64, File: /usr/local/www/includes/functions.inc.php, Line: 95, Message: Cannot redeclare cpu_usage() (previously declared in /usr/local/pkg/lcdproc_client.php:76)
Jul 13 22:04:30     php     46723     /usr/local/pkg/lcdproc_client.php: New alert found: PHP ERROR: Type: 64, File: /usr/local/www/includes/functions.inc.php, Line: 95, Message: Cannot redeclare cpu_usage() (previously declared in /usr/local/pkg/lcdproc_client.php:76)
Jul 13 22:05:41     LCDd     45886     Client on socket 6 disconnected

Actions #4

Updated by Cino . 10 months ago

I've updated to the newest package and life is good again. thank you

Actions #5

Updated by Jim Pingle 10 months ago

  • Status changed from Feedback to In Progress
  • % Done changed from 100 to 90

I have some ideas on why the button calls are hitting that error, I'll work on it some more.

Good to know the other parts are working at least.

Actions #6

Updated by Jim Pingle 10 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 90 to 100

This should be fixed now. I don't have a panel with buttons to test it (yet, it's on the way) but I see why it was failing before and it should be fixed and working now.

https://github.com/pfsense/FreeBSD-ports/commit/07d37baecc82fc4d7a4fe20641ce820bd537ab6d

Package version 0.11.1 is building now and will be available for testing shortly.

Actions #7

Updated by Soren Pedersen 10 months ago

@Jim Pringle:

I installed the updated version of LCDProc on PFsense 2.7.0 and the service still refuses to start. Removed LCDProc, reboot, and reinstall but same result.

Actions #8

Updated by Jim Pingle 10 months ago

Soren Pedersen wrote in #note-7:

@Jim Pringle:

I installed the updated version of LCDProc on PFsense 2.7.0 and the service still refuses to start. Removed LCDProc, reboot, and reinstall but same result.

Do you get the same PHP error or something different?

Actions #9

Updated by Jim Pingle 9 months ago

  • Status changed from Feedback to Resolved

The error as originally stated in this issue is solved. If you still have problems starting LCDProc, please post a new thread to follow up on the forum in the Packages category -- be sure to include any PHP errors that occur as well as any messages from LCDProc/LCDd found in the system log.

Actions #10

Updated by Jim Pingle 9 months ago

For the record, I now have an LCD with buttons and the fix I committed last week did correct the errors.

Actions

Also available in: Atom PDF