Project

General

Profile

Actions
Copy link

Bug #14619

closed

Rule separators are ordered incorrectly after removing rules in certain positions

Added by Marcos M 10 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marcos M
Category:
Rules / NAT
Target version:
2.7.1
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.09
Release Notes:
Default
Affected Version:
2.7.0
Affected Architecture:
All

Description

Steps to reproduce:
  1. Create three rules, and a separator between the second and third rule.
  2. Select the first two rules and click Delete.
  3. The third rule is now above the separator instead of below it.

Files

Download all files
Screenshot 2023-12-15 at 10.19.31 PM.png (842 KB) Screenshot 2023-12-15 at 10.19.31 PM.png Jonathan Lee, 12/16/2023 06:29 AM
Screenshot 2023-12-15 at 10.53.07 PM.png (1.53 MB) Screenshot 2023-12-15 at 10.53.07 PM.png Jonathan Lee, 01/17/2024 11:02 PM
Actions
Copy link
 #1

Updated by Jim Pingle 10 months ago

There were some recent changes made here in #9887 that fixed some other scenarios

Actions
Copy link
 #2

Updated by Marcos M 10 months ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Marcos M 10 months ago

  • Status changed from New to In Progress
  • Assignee set to Marcos M
Actions
Copy link
 #4

Updated by Marcos M 10 months ago

  • Subject changed from Rule separaters are ordered incorrectly after removing rules above it to Rule separators are ordered incorrectly after removing rules above it
Actions
Copy link
 #5

Updated by Marcos M 10 months ago

  • Status changed from In Progress to Pull Request Review
  • Target version set to 2.8.0
  • Plus Target Version set to 23.09
  • Affected Architecture All added
Actions
Copy link
 #6

Updated by Marcos M 9 months ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Marcos M 9 months ago

  • Status changed from Feedback to Resolved

Original issue is now fixed, and all test cases referenced in the attachments of #9887 pass as well; separators in the NAT rules page were also tested. This also fixes displaying rule separators with an out of range index.

Actions
Copy link
 #8

Updated by Jim Pingle 9 months ago

  • Subject changed from Rule separators are ordered incorrectly after removing rules above it to Rule separators are ordered incorrectly after removing rules in certain positions

Updating subject for release notes.

Actions
Copy link
 #9

Updated by Jonathan Lee 9 months ago

Side note:
I have also seen this behavior carrying into layer 2 Ethernet filtering rules.

Photos inside duplicate Redmine

https://redmine.pfsense.org/issues/14705

Actions
Copy link
 #10

Updated by Jim Pingle 6 months ago

  • Target version changed from 2.8.0 to 2.7.1
Actions
Copy link
 #11

Updated by Jonathan Lee 5 months ago

I still have issues with this in 23.05.01 and they all show up again in 23.09.01

I stopped using separators however they are all listed in my config.xml file as soon as I update to 23.09.01 they all show up again in opt1 however in 23.05.01 they are not listed but are in the config file. Can I just delete them in the config file? Will this cause issues. I was locked out and my rules keep getting mixed up

Actions
Copy link
 #12

Updated by Jonathan Lee 4 months ago

This fixed my issues

I made the config.xml file like this, they had issues in 23.05.01 I think they caused the ruleset mix up where it blocked everything for me on 23.09

Actions
Copy link

Also available in: Atom PDF