Project

General

Profile

Actions
Copy link

Bug #14619

closed
MM MM

Rule separators are ordered incorrectly after removing rules in certain positions

Bug #14619: Rule separators are ordered incorrectly after removing rules in certain positions

Added by Marcos M about 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marcos M
Category:
Rules / NAT
Target version:
2.7.1
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.09
Release Notes:
Default
Affected Version:
2.7.0
Affected Architecture:
All

Description

Steps to reproduce:
  1. Create three rules, and a separator between the second and third rule.
  2. Select the first two rules and click Delete.
  3. The third rule is now above the separator instead of below it.

Files

Download all files
Screenshot 2023-12-15 at 10.19.31 PM.png (842 KB) Screenshot 2023-12-15 at 10.19.31 PM.png Jonathan Lee, 12/16/2023 06:29 AM
Screenshot 2023-12-15 at 10.53.07 PM.png (1.53 MB) Screenshot 2023-12-15 at 10.53.07 PM.png Jonathan Lee, 01/17/2024 11:02 PM

JP Updated by Jim Pingle about 3 years ago Actions
Copy link
 #1

There were some recent changes made here in #9887 that fixed some other scenarios

MM Updated by Marcos M about 3 years ago Actions
Copy link
 #2

  • Description updated (diff)

MM Updated by Marcos M about 3 years ago Actions
Copy link
 #3

  • Status changed from New to In Progress
  • Assignee set to Marcos M

MM Updated by Marcos M about 3 years ago Actions
Copy link
 #4

  • Subject changed from Rule separaters are ordered incorrectly after removing rules above it to Rule separators are ordered incorrectly after removing rules above it

MM Updated by Marcos M about 3 years ago Actions
Copy link
 #5

  • Status changed from In Progress to Pull Request Review
  • Target version set to 2.8.0
  • Plus Target Version set to 23.09
  • Affected Architecture All added

MM Updated by Marcos M about 3 years ago Actions
Copy link
 #6

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:8a12728da23fc7cb654cec4a97670ef2b6dfb239.

MM Updated by Marcos M about 3 years ago Actions
Copy link
 #7

  • Status changed from Feedback to Resolved

Original issue is now fixed, and all test cases referenced in the attachments of #9887 pass as well; separators in the NAT rules page were also tested. This also fixes displaying rule separators with an out of range index.

JP Updated by Jim Pingle about 3 years ago Actions
Copy link
 #8

  • Subject changed from Rule separators are ordered incorrectly after removing rules above it to Rule separators are ordered incorrectly after removing rules in certain positions

Updating subject for release notes.

JL Updated by Jonathan Lee about 3 years ago Actions
Copy link
 #9

Side note:
I have also seen this behavior carrying into layer 2 Ethernet filtering rules.

Photos inside duplicate Redmine

https://redmine.pfsense.org/issues/14705

JP Updated by Jim Pingle almost 3 years ago Actions
Copy link
 #10

  • Target version changed from 2.8.0 to 2.7.1

JL Updated by Jonathan Lee over 2 years ago Actions
Copy link
 #11

I still have issues with this in 23.05.01 and they all show up again in 23.09.01

I stopped using separators however they are all listed in my config.xml file as soon as I update to 23.09.01 they all show up again in opt1 however in 23.05.01 they are not listed but are in the config file. Can I just delete them in the config file? Will this cause issues. I was locked out and my rules keep getting mixed up

JL Updated by Jonathan Lee over 2 years ago Actions
Copy link
 #12

This fixed my issues

I made the config.xml file like this, they had issues in 23.05.01 I think they caused the ruleset mix up where it blocked everything for me on 23.09

Actions
Copy link

Also available in: Atom