Project

General

Profile

Actions

Regression #14649

closed

PHP error with One.com Dynamic DNS provider

Added by Lev Prokofev 9 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Dynamic DNS
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.09
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

Tested on

23.05.1-RELEASE (amd64)
built on Wed Jun 28 03:57:27 UTC 2023
FreeBSD 14.0-CURRENT

Steps to reproduce:

go to Services=>Dynamic DNS
set one.com
feel the form
save.

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #1 plus-RELENG_23_05_1-n256108-459fc493a87: Wed Jun 28 04:26:04 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_05_1-main/obj/amd64/f2Em2w3l/var/jenkins/workspace/pfSense-Plus-snapshots-23_05_1-main/sources/

Crash report details:

PHP Errors:
[04-Aug-2023 08:23:20 Etc/GMT+4] PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string + string in /etc/inc/dyndns.class:1344
Stack trace:
#0 /etc/inc/dyndns.class(479): updatedns->_update()
#1 /etc/inc/services.inc(2348): updatedns->__construct('onecom', 'site101', 'lapplander.se', 'roger.lindquist...', 'VWpCSk4ybHZiRkV...', false, false, '', 'wan', NULL, NULL, NULL, '', false, '', '1', '', 'wan', '', '0', false, false, false, false)
#2 /usr/local/www/services_dyndns_edit.php(266): services_dyndns_configure_client(Array)
#3 {main}
  thrown in /etc/inc/dyndns.class on line 1344
[04-Aug-2023 08:25:45 Etc/GMT+4] PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string + string in /etc/inc/dyndns.class:1344
Stack trace:
#0 /etc/inc/dyndns.class(479): updatedns->_update()
#1 /etc/inc/services.inc(2348): updatedns->__construct('onecom', 'site101', 'prokleon.art', 'leonprok@gmail....', 'MTIz', false, false, '', 'wan', NULL, NULL, NULL, '', false, '', '1', '', 'wan', '', '1', false, false, false, false)
#2 /usr/local/www/services_dyndns_edit.php(266): services_dyndns_configure_client(Array)
#3 {main}
  thrown in /etc/inc/dyndns.class on line 1344
[04-Aug-2023 08:33:50 Etc/GMT+4] PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string + string in /etc/inc/dyndns.class:1344
Stack trace:
#0 /etc/inc/dyndns.class(479): updatedns->_update()
#1 /etc/inc/services.inc(2348): updatedns->__construct('onecom', 'site101', 'lapplander.se', 'roger.lindquist...', 'VWpCSk4ybHZiRkV...', false, false, '', 'wan', NULL, NULL, NULL, '', NULL, '', '1', '', 'wan', '', '0', false, false, false, NULL)
#2 /etc/inc/services.inc(2423): services_dyndns_configure_client(Array)
#3 /usr/local/www/services_dyndns.php(48): services_dyndns_configure()
#4 {main}
  thrown in /etc/inc/dyndns.class on line 1344
[04-Aug-2023 08:39:40 Etc/GMT+4] PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string + string in /etc/inc/dyndns.class:1344
Stack trace:
#0 /etc/inc/dyndns.class(479): updatedns->_update()
#1 /etc/inc/services.inc(2348): updatedns->__construct('onecom', 'site101', 'lapplander.se', 'roger.lindquist...', 'VWpCSk4ybHZiRkV...', false, false, '', 'wan', NULL, NULL, NULL, '', false, '', '1', '', 'wan', '', '0', false, false, false, false)
#2 /usr/local/www/services_dyndns_edit.php(266): services_dyndns_configure_client(Array)
#3 {main}
  thrown in /etc/inc/dyndns.class on line 1344
[04-Aug-2023 08:42:02 Etc/GMT+4] PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string + string in /etc/inc/dyndns.class:1344
Stack trace:
#0 /etc/inc/dyndns.class(479): updatedns->_update()
#1 /etc/inc/services.inc(2348): updatedns->__construct('onecom', 'site', 'lev.pro', 'leonprok@gmail....', 'VWpCSk4ybHZiRkV...', false, false, '', 'wan', NULL, NULL, NULL, '', false, '', '1', '', 'wan', '', '0', false, false, false, false)
#2 /usr/local/www/services_dyndns_edit.php(266): services_dyndns_configure_client(Array)
#3 {main}
  thrown in /etc/inc/dyndns.class on line 1344

No FreeBSD crash data found.
Actions #1

Updated by Georgiy Tyutyunnik 9 months ago

confirmed and reproduced on:
Version 2.7.0-RELEASE (amd64)
built on Wed Jun 28 03:53:34 UTC 2023
FreeBSD 14.0-CURRENT

Version 23.05.1-RELEASE (amd64)
built on Wed Jun 28 03:57:27 UTC 2023
FreeBSD 14.0-CURRENT

Actions #2

Updated by Jonathan Lee 9 months ago

https://redmine.pfsense.org/issues/14558

Could DoH support help with this?

Actions #3

Updated by Danilo Zrenjanin 7 months ago

  • Status changed from New to Confirmed

Tested against:

23.09-DEVELOPMENT (amd64)
built on 20230920-1314
FreeBSD 14.0-CURRENT

It's still broken.

Actions #4

Updated by Jim Pingle 7 months ago

  • Subject changed from Using the One.com dynamic DNS produces the PHP errors to PHP error with One.com Dynamic DNS provider
  • Assignee set to Jim Pingle
  • Target version set to 2.8.0
  • Plus Target Version set to 23.09
Actions #5

Updated by Jim Pingle 7 months ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions #6

Updated by Lev Prokofev 7 months ago

No more crashes after the patch, tested on

23.09-DEVELOPMENT (amd64)
built on 20230922-1539
FreeBSD 14.0-CURRENT
Actions #7

Updated by Jim Pingle 7 months ago

  • Status changed from Feedback to Resolved
Actions #8

Updated by Jim Pingle 6 months ago

  • Target version changed from 2.8.0 to 2.7.1
Actions

Also available in: Atom PDF