Feature #1482
closed
Captive Portal support for a configurable RADIUS NAS ID
0%
Description
When running network traces to examine the packets sent/received during Captive Portal authentication and accounting with RADIUS,
I noticed that pfSense Captive Portal uses the local host and domain name for the RADIS NAS ID. I can see this is set in /etc/inc/cativeposrtl.inc
in the function getNasID().
Do you intend to make this a configurable option?
This would help users migrating from DD-WRT WiFiGator configurations, such as myself :-)
You could implement the code here - http://mike.eire.ca/2010/08/25/setting-nas-id-on-pfsense/
Thanks, Richard
Files
Updated by Chris Buechler over 14 years ago
- Project changed from pfSense Packages to pfSense
Updated by Richard Gate over 14 years ago
Hi just found out that the code in /etc/inc/radius.inc function putStandardAttributes() does not call the getNasId() function but works out the NAS ID for itself in the same way that getNasId() does. So it will need updating to call getNasId() in a similar way that getNasIp() is a few lines before before.
Hope this helps, Richard
Updated by Jim Pingle almost 14 years ago
- Status changed from New to Feedback
There have been NAS IP options for CP in the code base for a while now.
Updated by Richard Gate almost 14 years ago
BTW its "NAS ID" not "NAS IP".
Assuming that was a typo, where can you set the "NAS ID" in the CP configuration?
Updated by Michael Newton almost 14 years ago
- File nasid.patch nasid.patch added
We're just putting together our first 2.0 boxes; it's currently untested, but I've attached the patch we're planning to try, based on our patch for 1.23 (that's my web page cited in the original report.) It would be nice to get this option added to the code.
Updated by Michael Newton almost 14 years ago
- File nasid.patch nasid.patch added
Forgot a global call.
Updated by Michael Newton almost 13 years ago
Seems the patch I submitted has disappeared; if there is still interest I will submit a pull request at github.com to get this into 2.1.
In the meantime, the patch for 2.01 and 2.02 is here: http://mike.eire.ca/2012/04/17/setting-nas-id-on-pfsense-2/
Updated by Richard Gate almost 13 years ago
I'd like to see the 2.1 patch get in there. Richard.
Updated by Ermal Luçi almost 13 years ago
Please send a pull request on github as everyone else since its easier to merge/review/...
Updated by Michael Newton almost 13 years ago
Updated by Ermal Luçi almost 13 years ago
Merged thank you for the pull request.
Updated by Chris Buechler almost 10 years ago
- Status changed from Feedback to Resolved