Project

General

Profile

Actions

Feature #1482

closed

Captive Portal support for a configurable RADIUS NAS ID

Added by Richard Gate about 14 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
04/26/2011
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:

Description

When running network traces to examine the packets sent/received during Captive Portal authentication and accounting with RADIUS,
I noticed that pfSense Captive Portal uses the local host and domain name for the RADIS NAS ID. I can see this is set in /etc/inc/cativeposrtl.inc
in the function getNasID().

Do you intend to make this a configurable option?
This would help users migrating from DD-WRT WiFiGator configurations, such as myself :-)
You could implement the code here - http://mike.eire.ca/2010/08/25/setting-nas-id-on-pfsense/

Thanks, Richard


Files

nasid.patch (5.8 KB) nasid.patch Patch against RELENG_2_0_1 Michael Newton, 03/11/2012 03:26 AM
nasid.patch (5.82 KB) nasid.patch Updated patch against RELENG_2_0_1 Michael Newton, 03/12/2012 06:12 PM
Actions #1

Updated by Chris Buechler about 14 years ago

  • Project changed from pfSense Packages to pfSense
Actions #2

Updated by Chris Buechler about 14 years ago

  • Assignee deleted (Ermal Luçi)
Actions #3

Updated by Richard Gate about 14 years ago

Hi just found out that the code in /etc/inc/radius.inc function putStandardAttributes() does not call the getNasId() function but works out the NAS ID for itself in the same way that getNasId() does. So it will need updating to call getNasId() in a similar way that getNasIp() is a few lines before before.
Hope this helps, Richard

Actions #4

Updated by Jim Pingle over 13 years ago

  • Status changed from New to Feedback

There have been NAS IP options for CP in the code base for a while now.

Actions #5

Updated by Richard Gate over 13 years ago

BTW its "NAS ID" not "NAS IP".
Assuming that was a typo, where can you set the "NAS ID" in the CP configuration?

Actions #6

Updated by Michael Newton over 13 years ago

We're just putting together our first 2.0 boxes; it's currently untested, but I've attached the patch we're planning to try, based on our patch for 1.23 (that's my web page cited in the original report.) It would be nice to get this option added to the code.

Actions #7

Updated by Michael Newton over 13 years ago

Forgot a global call.

Actions #8

Updated by Michael Newton over 12 years ago

Seems the patch I submitted has disappeared; if there is still interest I will submit a pull request at github.com to get this into 2.1.

In the meantime, the patch for 2.01 and 2.02 is here: http://mike.eire.ca/2012/04/17/setting-nas-id-on-pfsense-2/

Actions #9

Updated by Richard Gate over 12 years ago

I'd like to see the 2.1 patch get in there. Richard.

Actions #10

Updated by Ermal Luçi over 12 years ago

Please send a pull request on github as everyone else since its easier to merge/review/...

Actions #12

Updated by Ermal Luçi over 12 years ago

Merged thank you for the pull request.

Actions #13

Updated by Chris Buechler over 9 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF