Feature #1492
closed
Captive Portal Interim Updates
100%
Description
Currently there is nothing in webGUI to configure how often Captive Portal pruning should be executed. So the default of 60seconds is used.
This has the side affect that if RADIUS Accounting is been used then interim updates are sent every 60seconds.
captiveportal.inc does cater for this by using $config['captiveportal']['croninterval'] as the variable to startup the minicron, so all that needs to happen is services_captiveportal.php needs a field added for these updates.
What would a reasonable time frame be? Minimum 60 seconds, maximum 3600 seconds? Not sure if the latter is used how this would impact on Captive Portal pruning?
If it does then possibly interim updates needs to be split out from the pruning process?
Updated by Chris Buechler over 13 years ago
- Affected Version set to All
Not sure we want to expose this for 2.0, potential for fallout since that's never been exposed, though it's probably ok. Are there specific scenarios where this causes problems?
60-3600 is probably reasonable. Allowing too small of a number could lead to very large installs, or very slow boxes with quite a few users, to potentially have issues with running it multiple times simultaneously.
Updated by Michael Newton about 12 years ago
Ideally, pfSense should accept the Acct-Interim-Interval sent by the server to determine interim update interval, as other NAS devices do. I would agree this should be separate from the pruning interval, which needs to be a small value like 60 seconds.
Updated by Michael Newton about 12 years ago
Perhaps something like this, which is based on what we use in production for 2.0: https://github.com/bsdperimeter/pfsense/pull/237
Updated by Ermal Luçi almost 12 years ago
Merged manually without the GUI option.
Updated by Ermal Luçi almost 12 years ago
- % Done changed from 0 to 100
Applied in changeset 338c0941ef9a90d33b02627a320fb642d192b172.
Updated by Chris Buechler over 11 years ago
- Status changed from Feedback to Resolved