Bug #1532
closed
test_pfSpkg code breaks packages
0%
Description
Becuase the new test_pfSpkg() function gets added to each package's .inc file with the same name, the package system will fail when it tries to reinstall packages because the function with the same name is being redeclared. It causes the package reinstall process to bail.
The function name would need to be unique for each package, or some other mechanism to prevent the redeclaration of the function would have to be put in place.
Updated by Ermal Luçi over 14 years ago
- Target version changed from 2.0 to Future
This has been reverted and it will not make 2.0
Updated by Yehuda Katz over 14 years ago
This might be a long term change, but it might make sense to convert each package to a class which will prevent multiple name issues like this. (Wordpress is doing and recommending this now to avoid naming conflicts in plugins)
Because all pfSense installations use a controlled version of PHP, this should not cause any compatibility issues.
Updated by Chris Buechler almost 10 years ago
- Status changed from New to Closed
- Target version deleted (
Future) - Affected Version deleted (
2.0)
no longer relevant as that doesn't exist anymore