Project

General

Profile

Actions
Copy link

Feature #15323

open

Display server description when WOL is sent using mac url or power-on button

Added by Phil Wardt 10 months ago. Updated 9 days ago.

Status:
Pull Request Review
Priority:
Normal
Assignee:
-
Category:
Wake on LAN
Target version:
2.8.0
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
25.03
Release Notes:
Default

Description

When we use the send WOL to all devices link, the description of servers is properly printed
However, when we send WOL to a single server clicking on mac url or power-on button, the description is not printed

Fix this and properly display the description when sending WOL to a single server using both links

Files

services_wol-pf2.7.2-v1.0.php.patch (1.62 KB) services_wol-pf2.7.2-v1.0.php.patch Phil Wardt, 03/08/2024 09:33 PM
Actions
Copy link
 #1

Updated by Phil Wardt 10 months ago

Github commit:
https://github.com/pfsense/pfsense/pull/4673

And a patch file for current pfsense 2.7.2

Actions
Copy link
 #2

Updated by Jordan G 7 months ago

the described behavior is also present in the current version of pfSense+ as well (24.03)

Actions
Copy link
 #3

Updated by Jim Pingle 7 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.8.0
  • Plus Target Version set to 24.08
Actions
Copy link
 #4

Updated by Jim Pingle 2 months ago

  • Plus Target Version changed from 24.08 to 24.11
Actions
Copy link
 #5

Updated by Jim Pingle 2 months ago

  • Plus Target Version changed from 24.11 to 25.01
Actions
Copy link
 #6

Updated by Jim Pingle 13 days ago

  • Plus Target Version changed from 25.01 to 25.03
Actions
Copy link
 #7

Updated by Phil Wardt 11 days ago

I just noticed that the widget needs also a patch to display server description when wol is sent using the widget.
Should it be done on distinct commit than this ?

Actions
Copy link
 #8

Updated by Jim Pingle 11 days ago

Both could be on the same PR since they're for the same issue, but the PR needs work anyhow -- I left a comment on there.

It's helpful to use Git to squash the commits so they only appear as one commit in the PR, but not a hard requirement in most cases.

Actions
Copy link
 #9

Updated by Phil Wardt 9 days ago

Jim Pingle wrote in #note-8:

Both could be on the same PR since they're for the same issue, but the PR needs work anyhow -- I left a comment on there.

It's helpful to use Git to squash the commits so they only appear as one commit in the PR, but not a hard requirement in most cases.

Is it ok if I use hmtlspecialchars() instead, as I should've done from start in fact ? It'll make it safe in that case
Or you prefer the check from config entries ?

Actions
Copy link
 #10

Updated by Jim Pingle 9 days ago

While that method offers protection, it's still putting too much trust in user-supplied data to get passed around. Looking up the entry is better since it eliminates the concern entirely.

Actions
Copy link

Also available in: Atom PDF