Feature #15323
open
Display server description when WOL is sent using mac url or power-on button
Added by Phil Wardt about 1 year ago.
Updated about 2 months ago.
Status:
Pull Request Review
Plus Target Version:
25.07
Description
When we use the send WOL to all devices link, the description of servers is properly printed
However, when we send WOL to a single server clicking on mac url or power-on button, the description is not printed
Fix this and properly display the description when sending WOL to a single server using both links
Files
the described behavior is also present in the current version of pfSense+ as well (24.03)
- Status changed from New to Pull Request Review
- Target version set to 2.8.0
- Plus Target Version set to 24.08
- Plus Target Version changed from 24.08 to 24.11
- Plus Target Version changed from 24.11 to 25.01
- Plus Target Version changed from 25.01 to 25.03
I just noticed that the widget needs also a patch to display server description when wol is sent using the widget.
Should it be done on distinct commit than this ?
Both could be on the same PR since they're for the same issue, but the PR needs work anyhow -- I left a comment on there.
It's helpful to use Git to squash the commits so they only appear as one commit in the PR, but not a hard requirement in most cases.
Jim Pingle wrote in #note-8:
Both could be on the same PR since they're for the same issue, but the PR needs work anyhow -- I left a comment on there.
It's helpful to use Git to squash the commits so they only appear as one commit in the PR, but not a hard requirement in most cases.
Is it ok if I use hmtlspecialchars()
instead, as I should've done from start in fact ? It'll make it safe in that case
Or you prefer the check from config entries ?
While that method offers protection, it's still putting too much trust in user-supplied data to get passed around. Looking up the entry is better since it eliminates the concern entirely.
- Plus Target Version changed from 25.03 to 25.07
Also available in: Atom
PDF