Project

General

Profile

Actions

Bug #15502

closed
SW SW

Proxy variables in ``crontab`` contents are improperly formatted

Bug #15502: Proxy variables in ``crontab`` contents are improperly formatted

Added by Steve Wheeler over 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Operating System
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.11
Release Notes:
Default
Affected Version:
2.7.2
Affected Architecture:

Description

On systems with an upstream proxy configured lines are added to the crontab so commands run there see the appropriate environment variables.

Currently the proxy auth values are added on the same line:

[24.03-RELEASE][admin@plusdev-6.stevew.lan]/root: cat /etc/crontab 
#
# pfSense specific crontab entries
# Created: May 16, 2024, 9:39 pm
#
SHELL=/bin/sh
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin
HTTP_PROXY=172.21.16.185:3128HTTP_PROXY_AUTH=basic:*:test:12345
*/1    *    *    *    *    root    /usr/sbin/newsyslog

Those variables should be on separate lines.

In addition there should be variables for CURL: HTTPS_PROXY at least.

JP Updated by Jim Pingle over 2 years ago Actions #1

  • Subject changed from Crontab proxy settings incorrectly added to Proxy variables in ``crontab`` contents are improperly formatted
  • Status changed from New to Pull Request Review
  • Assignee set to Steve Wheeler

Updated by Anonymous over 2 years ago Actions #2

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:45419ed469e182e97b72f534ff4a79b6f531b06e.

GT Updated by Georgiy Tyutyunnik over 2 years ago Actions #3

tested on:
2.7.2-RELEASE (amd64)
built on Wed Dec 6 20:10:00 UTC 2023
FreeBSD 14.0-CURRENT

patch fixes the issue

MM Updated by Marcos M over 2 years ago Actions #4

  • Status changed from Feedback to Resolved

JP Updated by Jim Pingle over 2 years ago Actions #5

  • Plus Target Version changed from 24.07 to 24.08

JP Updated by Jim Pingle almost 2 years ago Actions #6

  • Plus Target Version changed from 24.08 to 24.11
Actions

Also available in: Atom