pfSense

The frontend and backend code in AutoConfigBackup needs a lot of review/cleanup.

• It's changed a lot over the years and there is quite a lot of unused/dead code, some commented out, some just not doing anything
• There are a lot of redundancies, especially in how cURL is called to query the ACB server
• Most of the strings are not run through gettext()
• There are a lot of inconsistencies in the wording/terminology for various items across the ACB GUI
• Iconography/buttons need better distinction/phrasing/colors
• The user isn't warned enough about protecting the device key and similar values
• Log messages are also inconsistent and not handled ideally in some cases, such as when performing batched uploads.
• There are inconsistencies between GET and POST operations when everything could use POST (And remove any use of $_REQUEST)
• Any other cleanup/updating that gets spotted along the way

I have implemented this as a part of other ongoing ACB work.