Project

General

Profile

Actions
Copy link

Bug #1662

closed

DNS server gateway selection missing input validation

Added by Chris Buechler over 13 years ago. Updated over 12 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
2.1
Start date:
07/10/2011
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1-IPv6
Affected Architecture:

Description

If a gateway is chosen for a DNS server on system.php, the gateway must be the same protocol as that of the DNS server. If the DNS server is an IPv4 IP, the gateway must be an IPv4 gateway. Same for IPv6.

Actions
Copy link
 #1

Updated by Seth Mos over 13 years ago

This same issue exists on the firewall rules (edit) page for selection of gateways.

I can fix the input validation but ideally a javascript wizard would prevent people from selecting a gateway from a different address family.

Actions
Copy link
 #2

Updated by Seth Mos over 13 years ago

  • Status changed from New to Feedback

Code checked in that converts the interface names to gateway names, updated the system.inc code that updates the routes.

Page only shows the gateways from the same address family on the drop down. Verification implemented on submit.

Actions
Copy link
 #4

Updated by Chris Buechler over 12 years ago

  • Status changed from Feedback to New
Actions
Copy link
 #5

Updated by Seth Mos over 12 years ago

  • Status changed from New to Feedback

Last commit should nail it.

This only happened when the system has just 1 gateway.

Actions
Copy link
 #6

Updated by Chris Buechler over 12 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF