Project

General

Profile

Bug #1993

Unmonitored gateways cause wrong route-to

Added by Chris Buechler about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Gateways
Target version:
Start date:
11/07/2011
Due date:
% Done:

100%

Estimated time:
4.00 h
Affected Version:
2.0
Affected Architecture:
All

Description

Gateways that aren't monitored end up being the only ones put into gateway groups reportedly.
http://forum.pfsense.org/index.php/topic,42731.0.html

Associated revisions

Revision f328ad12 (diff)
Added by Seth Mos about 8 years ago

Fix for redmine ticket #1993. Allow saving multiple dynamic entries.
Make sure that return_gateways_status() also returns all gateways that have monitoring disabled as up.

Revision 16106d2e (diff)
Added by Seth Mos about 8 years ago

Fix for redmine ticket #1993. Allow saving multiple dynamic entries.
Make sure that return_gateways_status() also returns all gateways that have monitoring disabled as up.

History

#1 Updated by Chris Buechler about 8 years ago

  • Subject changed from Unmonitored gateways are considered down to Unmonitored gateways cause wrong route-to

#2 Updated by Seth Mos about 8 years ago

  • Assignee set to Seth Mos

#3 Updated by Seth Mos about 8 years ago

Not sure what sort of interface configuration this applies to.
Setting up a tripple DHCP now

Ok. When I configure 3 DHCP entries I can only add the 1st as a editable entry on the gateways page. That's not supposed to happen. fixed edit page Bogus code that removes any system entries without settings, seems like a sane thing to do but does not take disabled monitor into account. Removing code snippet.

Add to the return_gateways_status() function so that unmonitored gateways are shown as up with 0 latency and loss.

*replicated. Issue in filter.inc. http://tinypaste.com/a7f2c466

#4 Updated by Seth Mos about 8 years ago

  • Status changed from New to Resolved
  • Target version set to 2.0.1
  • % Done changed from 0 to 100
  • Estimated time set to 4.00 h
  • Affected Architecture set to All

It appears that fixing the backend functions resolves the incorrect filter rule generation.

Also fixed a issue where a numerical gateway group would not be reffered to in the filter code. Array_merge() clobbers the number to 0 invalidating the rest of the code path. Thus it would never end up in the filter rules.

This fix should probably be included in 2.1 as well.

Also available in: Atom PDF