Project

General

Profile

Bug #233

Config upgrade should change theme

Added by Chris Buechler over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
Config upgrade
Target version:
Start date:
12/18/2009
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

If the default theme is selected in a 1.2.x config, it should be changed during the config upgrade to the new default theme in 2.0.

Associated revisions

Revision 57de741a (diff)
Added by Seth Mos about 9 years ago

Bump the config version properly so that the theme is properly upgraded. Ticket #233

History

#1 Updated by Scott Ullrich over 9 years ago

  • Status changed from New to Closed

There is no "default" theme. With that said it is impossible to detect this since there is no default.

For example, 2.0 ships with <theme>pfsense_ng</theme>

#2 Updated by Chris Buechler over 9 years ago

  • Status changed from Closed to New

There is a default theme, it's nervecenter. If <theme>nervecenter</theme>, s/nervecenter/pfsense_ng/

#3 Updated by Erik Fonnesbeck over 9 years ago

Personally, I don't think it should be done unless there is some way to detect that the user has not ever configured a different theme. Maybe they prefer it over pfsense_ng.

Possibly a one-time question with reasons why they might like to switch, but not an automatic change.

#4 Updated by Chris Buechler over 9 years ago

The check to change nervecenter only would ensure it never gets hit for anyone who has selected another theme.

nervecenter's top menus are hosed in 2.0 at the moment (System and Help overlap, System isn't usable), which is what makes this more desirable (plus fixing nervecenter, but that's a separate issue entirely).

#5 Updated by Erik Fonnesbeck over 9 years ago

If nervecenter does not get fixed and is removed from 2.0, I can see that as being a valid reason to change the theme from nervecenter to pfsense_ng when upgrading -- or if this is intended as a temporary measure until nervecenter is fixed.

#6 Updated by Seth Mos about 9 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Added Upgrade code 62 to 63, this allows us to convert deprecated legacy themes to pfsense_ng

Also available in: Atom PDF