Feature #262: Add NAT-PMP support to miniupnpd - pfSense - pfSense bugtracker

Actions

Copy link

Feature #262

closed

Add NAT-PMP support to miniupnpd

Added by Salvatore LaMendola over 14 years ago. Updated over 9 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

UPnP/NAT-PMP

Target version:

Start date:

12/30/2009

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Description

Hey guys I have a really easy one for you. I use a few programs that support NAT-PMP, and one, which actually claims to support both, yet only NAT-PMP support is actually functional. Is there any way you guys could enable NAT-PMP on the default install? I'm not much of a web programmer, but I could (enable the switch? compile it in? haven't used miniupnpd in a while...) definitely get this working in the program if someone better at web adds it to the interface. Thanks a lot.

Files

pfSense2-local-miniupnpd.patch (5.56 KB) pfSense2-local-miniupnpd.patch

Andrew Fernandes, 07/12/2010 08:49 PM

Actions

Copy link

Updated by Andrew Fernandes almost 14 years ago

File pfSense2-local-miniupnpd.patch pfSense2-local-miniupnpd.patch added

I've included a patch to allow NAT-PMP to be a "first class" citizen along with UPnP. This is important for us as well since we are a pure-Macintosh shop.

There are a few notes here:

First, miniupnpd must be updated to miniupnpd-1.4.20100511. Version 1.4 is in FreeBSD's ports now, and I have problem-report ports/148529 already logged to update miniupnpd in the FreeBSD mainline. The reason for the update is that 1.4 has a couple of bugs with respect to NAT-PMP (according to the changelog only the NAT-PMP changes should affect pfSense/FreeBSD).
Second, the pfSense GUI has been updated to refer to "UPnP" as "UPnP & NAT-PMP", in order to give NAT-PMP "first-class" look-and-feel. I used HTML entities for the ampersand and hope that is okay with developer policy.
Third, you can now allow UPnP and NAT-PMP independently. At least one must be allowed if the daemon is enabled.
Lastly, the miniupnpd process should report both protocol mappings correctly in the status page, and have both protocols use the same network queues.

Obviously, the maintainer needs to build a new /usr/local/sbin/miniupnpd in addition to the given patch.

Thanks for such excellent work, guys!

Actions

Copy link

Updated by Jim Pingle almost 14 years ago

Category set to UPnP/NAT-PMP

Thanks for the patch!

Does your FreeBSD PR for the port include a patch to update the port, or did you just ask for an update?

If you have a patch for the port to use the newer version, we can use that too.

Actions

Copy link

Updated by Jim Pingle almost 14 years ago

Nevermind, I missed the link to the PR in the original ticket info. Looks like it does have a patch. We can use that instead of waiting for the ports tree to catch up.

Actions

Copy link

Updated by Andrew Fernandes almost 14 years ago

I just (few minutes ago!) received an email from the FreeBSD port maintainer approving the miniupnpd port update. As soon as GNATS catches up it should be committed. I currently live in the MacPorts world so I don't know how fast/slow things work in the FreeBSD world... :-)

Actions

Copy link

Updated by Jim Pingle almost 14 years ago

Usually pretty quickly, it may take a while to show up on all the mirrors though.

I pulled your patch into our pfPorts section of the tools repo, since we already were using a custom miniupnpd port Makefile. (~~The commit should be showing up on this ticket~~ Or not, I forgot redmine doesn't see the tools commits, only the main repo).

Actions

Copy link