Bug #2763
closed
Dynamic Firewall logs doesn't add new rows
100%
Description
The Dynamic Firewall Log page doesn't add rows, it only updates the php generated rows which means that if it's loaded after the log is cleared, it'll never show any activity. The same occurs for the log widget.
It also uses divs and absolutely sized spans instead of tables like the other log pages, meaning that the dynamic log can't change with variable width pages.
I've patched 4 files to make/usr/local/www/diag_logs_filter_dynamic.php- Modified to render the log in tables rather than divs/usr/local/www/javascript/filter_log.js- Modified to support addition or insertion of rows, so that the table will grow to the number of rows specified bynentries/usr/local/www/widgets/widgets/log.widget.php- Modified to render the log in tables rather than divs, this uses a fixed table layout and truncates the log info with an ellipsis (title attributes are used to display the full cell text)/usr/local/www/css/table.css- Added ellipsis css class that provides truncating cell contents.
Files
| dynamic_log.diff (13.4 KB) dynamic_log.diff | |||
| log_widget.png (11.5 KB) log_widget.png | |||
| Widget - Modified.png (12 KB) Widget - Modified.png | |||
| log_widget_with_align.png (13.2 KB) log_widget_with_align.png | |||
| log_widget_without_align.png (12.9 KB) log_widget_without_align.png |
Updated by Renato Botelho almost 12 years ago
- File log_widget.png log_widget.png added
- Status changed from New to Feedback
- Assignee set to Renato Botelho
Widget is working fine, but there is something wrong with fonts and sizes as you can see on attached screenshot.
Updated by John Bayly almost 12 years ago
- File Widget - Modified.png Widget - Modified.png added
I'm guessing that you mean the column headers? I just copied across the span width values onto the column headers, but those widths don't work so cell with table cells. On a second look, the percentages didn't even add up to 100%!
How does it look if the column widths are modified as such:
<colgroup>
<col style="width: 8%;">
<col style="width: 10%;">
<col style="width: 35%;">
<col style="width: 35%;">
<col style="width: 12%;">
</colgroup>
If you mean the cell values being truncated, the problem I was having with the original Widget was that the contents overflowed into each other - making them unreadable. Hovering the mouse over the entry should display the full cell value.
Updated by Renato Botelho almost 12 years ago
- File log_widget_with_align.png log_widget_with_align.png added
- File log_widget_without_align.png log_widget_without_align.png added
Column widths looks good with new values, but rows height doesn't. Take a look at new attachments, seems the Act icon is not vertically aligned. Removing align="middle" from <a> improves it a bit.
Updated by John Bayly almost 12 years ago
I'd agree with that, the reason I hadn't noticed was that in [my version] of Chrome, I don't see the alignment problem, but I do in Firefox. I took that html from diag_logs_filter.php, and I see the same rendering differences between Firefox and Chrome on diag_logs_filter.php too. How about yourself?
My suggestion would be to remove the align="middle" attribute from all the filter log pages.
Updated by Renato Botelho almost 12 years ago
- % Done changed from 0 to 100
Applied in changeset c251f8ccc84a7595bb14ccdd9754321c54762eaf.
Updated by Renato Botelho almost 12 years ago
- Status changed from Feedback to Closed