Project

General

Profile

Actions
Copy link

Bug #2763

closed

Dynamic Firewall logs doesn't add new rows

Added by John Bayly almost 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Renato Botelho
Category:
Web Interface
Target version:
2.1
Start date:
01/18/2013
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

The Dynamic Firewall Log page doesn't add rows, it only updates the php generated rows which means that if it's loaded after the log is cleared, it'll never show any activity. The same occurs for the log widget.

It also uses divs and absolutely sized spans instead of tables like the other log pages, meaning that the dynamic log can't change with variable width pages.

I've patched 4 files to make
  1. /usr/local/www/diag_logs_filter_dynamic.php - Modified to render the log in tables rather than divs
  2. /usr/local/www/javascript/filter_log.js - Modified to support addition or insertion of rows, so that the table will grow to the number of rows specified by nentries
  3. /usr/local/www/widgets/widgets/log.widget.php - Modified to render the log in tables rather than divs, this uses a fixed table layout and truncates the log info with an ellipsis (title attributes are used to display the full cell text)
  4. /usr/local/www/css/table.css - Added ellipsis css class that provides truncating cell contents.

Files

Download all files
dynamic_log.diff (13.4 KB) dynamic_log.diff John Bayly, 01/18/2013 06:03 AM
log_widget.png (11.5 KB) log_widget.png Renato Botelho, 01/24/2013 07:16 PM
Widget - Modified.png (12 KB) Widget - Modified.png John Bayly, 01/25/2013 04:45 AM
log_widget_with_align.png (13.2 KB) log_widget_with_align.png Renato Botelho, 01/25/2013 06:01 AM
log_widget_without_align.png (12.9 KB) log_widget_without_align.png Renato Botelho, 01/25/2013 06:01 AM
Actions
Copy link

Also available in: Atom PDF