pfSense

Updated to "2.1-BETA1 (i386) built on Thu Feb 14 16:27:05 EST 2013" and
tried to tried to clear / apply / reconfigure / apply but same result.
Still does not get IPv4 addresses populated in the ipsecpinghosts.

/Dan Lundqvist

The correction does not work.
The problem is that the $ipsecpinghosts is NOT treated as a table but rather as a single string.
Regardless where you place the @file_put_contents it will only contain the last read string into the $ipsecpinghosts when it is saved.

I am not 100% sure how the @file_put_contents function if it overwrites the file every time or appends ?
I suspect that every time when you try to do the @file_put_contents it overwrites any previous data so even if you
move it closer into the "foreach" loop it will still get the same result as file/data is getting overwritten every time.

At least this is what I am seeing when I am doing troubleshooting.

Looks like someone needs to rethink this and make a new correction.

//Dan Lundqvist

Or there is something wrong so it doesn't create an array even if it suppose to do it (the $ipsecpinghosts*[]* )
Or there is something wrong that the @file_put_contents doesn't detect that it should save it as an array
and save it as a single-string (just getting the last item in the array).

http://php.net/manual/en/function.file-put-contents.php

If I try to remove the IPv6 AutoPing IP (that is the 3rd IPsec tunnel), the IP from the 2nd IPsec shows up in the
ipsecpinghosts file but only that item.

//Dan Lundqvist

I think I found the problem.

It needed to be even one more step out of the loop at the end of the foreach phase1 loop as you are doing an “unset($ipsecpinghosts);” which clears the variable
so it was cleared at every phase2 iteration instead of after the whole phase1/phase2 iteration causing only the last phase2 iteration to stick in the file.
I have now tested this and now it works OK...

}
                            $dstip = $ph2ent['pinghost'];
                            if(is_ipaddrv6($dstip)) {
                                $family = "inet6";
                            } else {
                                $family = "inet";
                            }
                            if (is_ipaddr($srcip))
                                $ipsecpinghosts[] = "{$srcip}|{$dstip}|3|||||{$family}|\n";
                        }
                    }
ORIGINAL PLACE BEFORE CORRECTION
                }
OLD PLACE BY YOUR CORRECTION
            }
NEW PLACE            @file_put_contents("{$g['vardb_path']}/ipsecpinghosts", $ipsecpinghosts);
NEW PLACE            unset($ipsecpinghosts);
        }

//Dan Lundqvist

Applied in changeset 923e440b75eda660a5cdbd102912fe53d61d1237.

Thanks for that Renato. :-)

//Dan