Project

General

Profile

Actions
Copy link

Bug #2941

closed
CB RB

Prohibit adding aliases containing FQDNs in static routes

Bug #2941: Prohibit adding aliases containing FQDNs in static routes

Added by Chris Buechler over 13 years ago. Updated about 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
Routing
Target version:
2.1
Start date:
04/09/2013
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1
Affected Architecture:

Description

aliases containing FQDNs cannot be used in static routes, need input validation to prevent that config from being used.

Files

Download all files
Add_FQDN_Alias_Static_Route.PNG (21.6 KB) Add_FQDN_Alias_Static_Route.PNG Josh Cavalier, 07/02/2013 12:35 AM
Alias_change_to_FQDN_static_route.PNG (25.5 KB) Alias_change_to_FQDN_static_route.PNG Josh Cavalier, 07/02/2013 01:00 AM

CB Updated by Chris Buechler over 13 years ago Actions
Copy link
 #1

  • Subject changed from aliases containing FQDNs are not usable in static routes to Prohibit adding aliases containing FQDNs in static routes

RB Updated by Renato Botelho over 13 years ago Actions
Copy link
 #2

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:8543a5bbe2037c9214f967806f417c7c4ba3b062.

CB Updated by Chris Buechler over 13 years ago Actions
Copy link
 #3

  • Status changed from Feedback to New

on system_routing_edit.php, this only works if the first item in the alias list is a hostname. It works correctly on firewall_aliases_edit.php.

RB Updated by Renato Botelho over 13 years ago Actions
Copy link
 #4

  • Status changed from New to Feedback

Applied in changeset commit:5b431a20dead1128687453407a3b0c603154e773.

JS Updated by Josh Stompro over 13 years ago Actions
Copy link
 #5

I'm trying to confirm that this is fixed but I'm not having success. May 2nd 2.1 snapshot, well past when the change was made.

I create an alias with a single host FQDN, save it and apply the change. Then I go to the System Static Routes and add a route using that Alias. And the process completes without any trouble, no error is displayed.

I then deleted the route, and I went back to my alias and changed it to a network alias with a FQDN entry. And I could still use it in a static route.

Maybe I'm not testing the correct thing, could someone describe how to trigger this problem.

Here are the alias and static route config entries.

<route>
            <network>Testing</network>
            <gateway>Openvpn</gateway>
            <descr><![CDATA[test]]></descr>
</route>
<alias>
            <name>Testing</name>
            <address>firewall.larl.org</address>
            <descr><![CDATA[testing]]></descr>
            <type>network</type>
            <detail><![CDATA[larl.org]]></detail>
</alias>

RB Updated by Renato Botelho over 13 years ago Actions
Copy link
 #6

Josh,

Are you using a recent snapshot?

RB Updated by Renato Botelho over 13 years ago Actions
Copy link
 #7

  • Assignee set to Renato Botelho

JS Updated by Josh Stompro over 13 years ago Actions
Copy link
 #8

I'm running the May 2nd snapshot, which seems to have the patches listed in this ticket.

Was I testing correctly? Should I have hit the error message with my test?

Thanks
Josh

CB Updated by Chris Buechler over 13 years ago Actions
Copy link
 #9

  • Status changed from Feedback to New

still the same as what I noted in an earlier update. It's correct on the alias edit screen, but on system_routes_edit.php it doesn't work.

RB Updated by Renato Botelho over 13 years ago Actions
Copy link
 #10

  • Status changed from New to Feedback

Applied in changeset commit:0d59cc942f2ee225eccdb375e25f58a6f04fa9c4.

RB Updated by Renato Botelho over 13 years ago Actions
Copy link
 #11

Applied in changeset commit:fcb1ccaf2d356148057e9a62a376ce3d4229e980.

RB Updated by Renato Botelho over 13 years ago Actions
Copy link
 #12

Applied in changeset commit:5e2df7fc1c71c2e876e8eb1f99f7b3c8419ea72c.

RB Updated by Renato Botelho over 13 years ago Actions
Copy link
 #13

Applied in changeset commit:f0867239c1b15c711ea3c6eefd896c2d2aaefcae.

JC Updated by Josh Cavalier about 13 years ago Actions
Copy link
 #14

I have tested this with the latest build and it works as intended. I created two aliases, one with a FQDN and one with an IP4 IP. I could add the IP alias but not the FQDN alias. Error message is "The alias (test1) has one or more FQDNs configured and cannot be used to configure a static route."

JC Updated by Josh Cavalier about 13 years ago Actions
Copy link
 #15

Also, I have replicated the test by Josh Stompro above (changing an existing alias used by a static route from IP to FQDN) and firewall_aliases_edit.php now responds with "This alias is used on a static route and cannot contain FQDNs".

CB Updated by Chris Buechler about 13 years ago Actions
Copy link
 #16

  • Status changed from Feedback to Resolved

confirmed fixed

RD Updated by Rahman Duran about 13 years ago Actions
Copy link
 #17

Hi,

It seems this fix broke using nested aliases for static routing as system_routes_edit.php line 131-138 assumes members of the alias are ipaddr. So please change the status of this bug.

RB Updated by Renato Botelho about 13 years ago Actions
Copy link
 #18

  • Status changed from Resolved to New

Nested aliases are still broken, working on it

RB Updated by Renato Botelho about 13 years ago Actions
Copy link
 #19

  • Status changed from New to Feedback

Applied in changeset commit:90bc28cc9d75c59efc06a3aa319239bf7aafa259.

CB Updated by Chris Buechler about 13 years ago Actions
Copy link
 #20

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom