Project

General

Profile

Actions

Bug #2941

closed

Prohibit adding aliases containing FQDNs in static routes

Added by Chris Buechler over 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
Routing
Target version:
Start date:
04/09/2013
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1
Affected Architecture:

Description

aliases containing FQDNs cannot be used in static routes, need input validation to prevent that config from being used.


Files

Actions #1

Updated by Chris Buechler over 8 years ago

  • Subject changed from aliases containing FQDNs are not usable in static routes to Prohibit adding aliases containing FQDNs in static routes
Actions #2

Updated by Renato Botelho over 8 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #3

Updated by Chris Buechler over 8 years ago

  • Status changed from Feedback to New

on system_routing_edit.php, this only works if the first item in the alias list is a hostname. It works correctly on firewall_aliases_edit.php.

Actions #4

Updated by Renato Botelho over 8 years ago

  • Status changed from New to Feedback
Actions #5

Updated by Josh Stompro over 8 years ago

I'm trying to confirm that this is fixed but I'm not having success. May 2nd 2.1 snapshot, well past when the change was made.

I create an alias with a single host FQDN, save it and apply the change. Then I go to the System Static Routes and add a route using that Alias. And the process completes without any trouble, no error is displayed.

I then deleted the route, and I went back to my alias and changed it to a network alias with a FQDN entry. And I could still use it in a static route.

Maybe I'm not testing the correct thing, could someone describe how to trigger this problem.

Here are the alias and static route config entries.

<route>
            <network>Testing</network>
            <gateway>Openvpn</gateway>
            <descr><![CDATA[test]]></descr>
</route>
<alias>
            <name>Testing</name>
            <address>firewall.larl.org</address>
            <descr><![CDATA[testing]]></descr>
            <type>network</type>
            <detail><![CDATA[larl.org]]></detail>
</alias>

Actions #6

Updated by Renato Botelho over 8 years ago

Josh,

Are you using a recent snapshot?

Actions #7

Updated by Renato Botelho over 8 years ago

  • Assignee set to Renato Botelho
Actions #8

Updated by Josh Stompro over 8 years ago

I'm running the May 2nd snapshot, which seems to have the patches listed in this ticket.

Was I testing correctly? Should I have hit the error message with my test?

Thanks
Josh

Actions #9

Updated by Chris Buechler over 8 years ago

  • Status changed from Feedback to New

still the same as what I noted in an earlier update. It's correct on the alias edit screen, but on system_routes_edit.php it doesn't work.

Actions #10

Updated by Renato Botelho over 8 years ago

  • Status changed from New to Feedback
Actions #14

Updated by Josh Cavalier over 8 years ago

I have tested this with the latest build and it works as intended. I created two aliases, one with a FQDN and one with an IP4 IP. I could add the IP alias but not the FQDN alias. Error message is "The alias (test1) has one or more FQDNs configured and cannot be used to configure a static route."

Actions #15

Updated by Josh Cavalier over 8 years ago

Also, I have replicated the test by Josh Stompro above (changing an existing alias used by a static route from IP to FQDN) and firewall_aliases_edit.php now responds with "This alias is used on a static route and cannot contain FQDNs".

Actions #16

Updated by Chris Buechler over 8 years ago

  • Status changed from Feedback to Resolved

confirmed fixed

Actions #17

Updated by Rahman Duran over 8 years ago

Hi,

It seems this fix broke using nested aliases for static routing as system_routes_edit.php line 131-138 assumes members of the alias are ipaddr. So please change the status of this bug.

Actions #18

Updated by Renato Botelho over 8 years ago

  • Status changed from Resolved to New

Nested aliases are still broken, working on it

Actions #19

Updated by Renato Botelho over 8 years ago

  • Status changed from New to Feedback
Actions #20

Updated by Chris Buechler about 8 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF