Project

General

Profile

Bug #3207

bug/feature expansion: ufslabels.sh doesn't account for gmirror systems.

Added by Andrew Stuart over 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
09/16/2013
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

Attempting to run ufslabels.sh on a system using gmirror gives the following:

sed: 1: "s/mirror/gm0s1a/ufsid\/ ...": bad flag in substitute command: 'u'
FS: / on device mirror/gm0s1a with ufsid 46404044387e2bbf
FS: Swap on device mirror/gm0s1b
sed: 1: "s/mirror/gm0s1b/label\/ ...": bad flag in substitute command: 'l'
====================
Current fstab:
# Device                Mountpoint      FStype  Options         Dump    Pass#
/dev/mirror/gm0s1a      /               ufs     rw              1       1
/dev/mirror/gm0s1b      none            swap    sw              0       0
====================
New fstab:
# Device                Mountpoint      FStype  Options         Dump    Pass#
/dev/mirror/gm0s1a      /               ufs     rw              1       1
/dev/mirror/gm0s1b      none            swap    sw              0       0
Commit changes? (y/n):

It might make sense to detect that it is a gmirror and to display a message accordingly vs spitting out errors.
At least if someone isn't paying attention, it doesn't appear to break things.. (though I didn't say yes to verify that)

Associated revisions

Revision c4eeb1c4 (diff)
Added by Jim Pingle over 7 years ago

Fix ufslabels.sh logic to avoid trying to convert slices which are already using appropriate labels. Fixes #3207

Revision 336e899a (diff)
Added by Jim Pingle over 7 years ago

Fix ufslabels.sh logic to avoid trying to convert slices which are already using appropriate labels. Fixes #3207

History

#1 Updated by Jim Pingle over 7 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Chris Buechler over 6 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF