Project

General

Profile

Actions

Bug #3222

closed

Firewall URL table aliases "Update Freq." has no units

Added by badon _ over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
09/22/2013
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1
Affected Architecture:

Description

In firewall_aliases_edit.php on line 503, find:

$update_freq_str = gettext("Update Freq.");

and change it to:

$update_freq_str = gettext("Update days");

"days" are the units in a dropdown menu, from 1 to 128 days. I learned the units were days from Bug #2685: Unnecessary fields in firewall aliases edit page. Replacing "Freq." with "days" puts units on the values in the dropdown, and its 1 character shorter! It's also translatable, searchable, etc. "Freq" and similar abbreviations are unnecessary, and as useless and annoying as abbreviating "abbreviation" with "abbr", as found in some paper dictionaries. If you want to make these form fields luxurious, I suggest changing line 503 to one of the following:

$update_freq_str = gettext("Days to update");

$update_freq_str = gettext("Update in days");

$update_freq_str = gettext("Fetch every (days)");

$update_freq_str = gettext("Update every (days)");

$update_freq_str = gettext("Update time in days");

$update_freq_str = gettext("Update time (days)");

$update_freq_str = gettext("Update frequency in days");

$update_freq_str = gettext("Update frequency (days)");

$update_freq_str = gettext("Update interval in days");

$update_freq_str = gettext("Update interval (days)");

$update_freq_str = gettext("Update schedule in days");

$update_freq_str = gettext("Update schedule (days)");

Of course, a better solution would be to not have a huge list of day numbers from 1 to 128, and instead have a more flexible and standard FreeBSD crontab format with the following fields:

minutes hours day-of-the-month month day-of-the-week

Described here:

http://www.freebsd.org/doc/handbook/configtuning-cron.html

Then, virtually anyone's needs can be served. I like having simple fields for people who don't want to read documentation about how to interpret crontab fields, so having a basic setting dialog with only minutes, hours, and days ought to be sufficient for most people. I think I would prefer that being implemented first.

Does anyone choose a number of 128 days? I'd bet my left arm that no one has ever needed exactly 128 days to update their alias URL table. Anyone who needs to update such information is likely to prefer that it gets updated as frequently as possible. In that case, a maximum frequency of 1 day could be unsatisfactory for nearly everyone. For myself, I would like an update frequency of 1 to 15 minutes.

Actions #1

Updated by Renato Botelho over 10 years ago

  • Status changed from New to Resolved

I changed the text to clarify freq. is in days. Abou the other changes you suggested, feel free to send a pull request.

Actions #2

Updated by badon _ over 10 years ago

Renato Botelho wrote:

I changed the text to clarify freq. is in days. Abou the other changes you suggested, feel free to send a pull request.

Pardon the newbie question, this is my first bug report for pfSense (and I haven't found any other bugs). What is a "pull request"? Also, where can I check to see the change that was made?

Actions #3

Updated by Renato Botelho over 10 years ago

You reported an issue, saying the update freq. unit was missing and it's confuse, this issue was fixed and for this reason I closed the ticket.

You also said that would be good if you can choose the unit, like a regular cronjob can do. It's not a bug but an improvement, a new feature.

To have a new feature implemented you can open a new ticket set as 'Feature' and wait until any developer take it to do or you can do the change and send us a patch. Since pfSense code is hosted on github, the way you submit a patch to a repo is using a pull request. You can read more about it here: https://help.github.com/articles/using-pull-requests

Actions

Also available in: Atom PDF