new version of <include_file> is not required during reinstall_all
When an outdated version of a package is installed and pfSense is updated, it will call pkg_reinstall_all() on next boot.
This function calls uninstall_package() what will call require_once() for files on tag <include_file> of the old version of the package
After this install_package() will be called, and will try to require_once() the new version of include_file, what will not be done
This can cause issues on the installation of new version of the package.
#1 Updated by Pi Ba over 6 years ago
Not having this install_package called from the new updated file could cause some packages to 'break', because of being miss-configured. While actually upgrade code is in place as part of the package installation scripts, though the workaround is easy to re-install a second time, its not what would be expected. This issue was also seen in #4135 which was marked as a duplicate of this issue.
It not only happens when doing a firmware-upgrade > pkg_reinstall_all(), but also when a new version of a single package takes place using the 'reinstall' button.
Though even if its not a high priority issue, and the workaround is easy to those who think about trying re-installing again, it would be nice if this could be fixed.